[CLOSED] Added support for sidebar resize on drag

brackets-archive / bracketsIssues

Archive of issues in brackets.

0 stars 0 forks source link

[CLOSED] Added support for sidebar resize on drag #793

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by ryanstewart Thursday May 03, 2012 at 17:39 GMT Originally opened as https://github.com/adobe/brackets/pull/798

Round 2. This pull request adds support for resizing the sidebar with a drag. Some notes:

It snaps closed when the sidebar gets within 10 pixels of the edge.
It's hooked into the other sidebar code so the Hide/Show Sidebar menu will be correct

It should be pretty self-contained because it's set up within its own initHandlers function.

ryanstewart included the following code: https://github.com/adobe/brackets/pull/798/commits

core-ai-bot commented 3 years ago

Comment by njx Friday May 04, 2012 at 04:49 GMT

I did an initial review, but you should probably get@jason-sanjose to look at the sidebar changes to make sure there isn't something I'm missing there.@peterflynn might also have an opinion on the right way to notify things in the sidebar that the sidebar's width is changing.

core-ai-bot commented 3 years ago

Comment by njx Friday May 04, 2012 at 19:29 GMT

Oops! sorry, clicked the wrong button. Didn't mean to close this.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Saturday May 05, 2012 at 01:36 GMT

Added some comments to NJ's thorough review.

core-ai-bot commented 3 years ago

Comment by ryanstewart Sunday May 06, 2012 at 06:46 GMT

Okay, thanks SO much for all the feedback. This new commit fixes all of the issues above. The only semi-hanging issue is the best way to notify everyone that the sidebar has been resized. I started putting some of the sidebar/resize logic into ProjectManager and I'd like to wait until that's been refactored to implement a better solution.

So if that's okay, I think it's a pretty solid pull request and ready for one last once-over.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Monday May 07, 2012 at 17:28 GMT

I'll take a look

core-ai-bot commented 3 years ago

Comment by ryanstewart Monday May 07, 2012 at 23:35 GMT

New commit that cleans up the things Jason mentioned above.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Monday May 07, 2012 at 23:43 GMT

Merging