Open core-ai-bot opened 3 years ago
Comment by redmunds Wednesday May 09, 2012 at 23:05 GMT
I think there may be some cases that you missed. Take a look in strings.js and search for the string "<span class='dialog-filename'>{ [n] }</span>", then search for where each of those strings that embed a filename are used.
Comment by tvoliter Friday May 11, 2012 at 22:53 GMT
Thanks Randy.
Since this is a bug fix for a non sprint 8 bug I'll come back to this after sprint 8 is complete since I am focused on wrappng that up.
Comment by tvoliter Wednesday May 16, 2012 at 23:45 GMT
Hi Randy, thanks for the review. Fixes have been pushed for the places I missed
Comment by redmunds Thursday May 17, 2012 at 18:20 GMT
@
tvoliter this looks good, but you'll need to merge the latest code before i can merge it into master.
Comment by tvoliter Thursday May 17, 2012 at 18:53 GMT
All set. Just merged.
Ty
-----Original Message----- From: Randy Edmunds [mailto:reply@reply.github.com] Sent: Thursday, May 17, 2012 11:21 AM To: Ty Voliter Subject: Re: [brackets] Fix issue 723 - Filenames not escaped properly in confirmation dialogs (#843)
@
tvoliter this looks good, but you'll need to merge the latest code before i can merge it into master.
Reply to this email directly or view it on GitHub: https://github.com/adobe/brackets/pull/843#issuecomment-5770475
Issue by tvoliter Tuesday May 08, 2012 at 23:23 GMT Originally opened as https://github.com/adobe/brackets/pull/843
Adds HTML escaping around filepath strings passed to dialogs for display
fixes issue #723
tvoliter included the following code: https://github.com/adobe/brackets/pull/843/commits