search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Project panel bug fixes #840

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by jasonsanjose Wednesday May 09, 2012 at 00:43 GMT Originally opened as https://github.com/adobe/brackets/pull/845

FYI@ryanstewart - Opportunistic refactor of sidebar resize handling to clean up dependencies in ProjectManager.js and brackers.js. Sets the stage for a future ProjectManager UI separation.

jasonsanjose included the following code: https://github.com/adobe/brackets/pull/845/commits

core-ai-bot commented 3 years ago

Comment by gruehle Wednesday May 09, 2012 at 19:56 GMT

Reviewing

core-ai-bot commented 3 years ago

Comment by gruehle Wednesday May 09, 2012 at 21:45 GMT

I found a bug in the new implementation:

  1. Open brackets/src folder (if not already open), and make sure all top-level folders are closed
  2. Open the editor folder
  3. Select Editor.js
  4. Close the editor folder (the editor folder itself should now be highlighted)
  5. Open the document folder

Results: DocumentCommandHandlers.js is highlighted, but not selected.

core-ai-bot commented 3 years ago

Comment by gruehle Wednesday May 09, 2012 at 22:06 GMT

Done with initial review. Looks like you need to do another merge with master.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Thursday May 10, 2012 at 00:07 GMT

Fixed the bug Glenn found. Merged with master.

core-ai-bot commented 3 years ago

Comment by ryanstewart Thursday May 10, 2012 at 00:11 GMT

Sweet, thanks for cleaning all this up@jason-sanjose. Looking forward to seeing it land.

core-ai-bot commented 3 years ago

Comment by gruehle Thursday May 10, 2012 at 00:44 GMT

Found another bug:

  1. Double click to close the sidebar
  2. Move the cursor near the left edge of the window until it turns into a resize cursor
  3. Try to drag the sidebar open. Problem 1: can't
  4. Realize that didn't work, so you try double-clicking. Problem 2: doesn't reopen
  5. Realize that didn't work, so you select "Show Sidebar". Problem 3: doesn't reopen
  6. Figuring "aw, what the heck", you try selecting "Show Sidebar" again. IT WORKS! :-)
core-ai-bot commented 3 years ago

Comment by gruehle Thursday May 10, 2012 at 01:41 GMT

I just noticed another issue too: the editor shadow is not adjusted when the window is resized. Open a file, scroll a bit so you get the shadow and make the window wider. The shadow doesn't get wider.

core-ai-bot commented 3 years ago

Comment by jasonsanjose Thursday May 10, 2012 at 03:26 GMT

Fixed the Glenn's latest issues.

core-ai-bot commented 3 years ago

Comment by gruehle Thursday May 10, 2012 at 14:33 GMT

Thanks, Jason. Everything is looking great, but there is one last minor issue: when the sidebar is collapsed, if you drag it slowly to open it, it always snaps shut. If you drag it really fast you can get it to open. It looks like this is due to the mousemove logic that snaps the sidebar closed when e.clientX < 10.

core-ai-bot commented 3 years ago

Comment by gruehle Thursday May 10, 2012 at 17:52 GMT

Looks great! Merging.