search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Pressing Undo when nothing can be undone makes Redo take more invocations #863

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by peterflynn Friday May 11, 2012 at 19:53 GMT Originally opened as https://github.com/adobe/brackets/issues/868

  1. Open any file -- make sure it was just opened, so its undo/redo history is totally clean at first
  2. Type "a"
  3. Undo
  4. Hit Undo another 4 times
  5. Redo

Result: nothing happens. You have to hit Redo 5 times to redo the "a" insertion.

Expected: hitting Redo once should redo the "a". The extra 4 Undo invocations should have been no-ops since we were already at the beginning of the history. It's as if Undo backed up further into "negative" slots on the history stack.

core-ai-bot commented 3 years ago

Comment by peterflynn Friday May 11, 2012 at 19:54 GMT

This repros in Sprint 7 so it's not related to the recent dirty/clean changes (#826).

core-ai-bot commented 3 years ago

Comment by peterflynn Friday May 11, 2012 at 19:59 GMT

Ok, looks like it's a CodeMirror bug. It doesn't repro in the online CodeMirror demo, so I'd assumed it was our bug -- but in our local copy of the CM demos it does repro.

core-ai-bot commented 3 years ago

Comment by njx Tuesday May 15, 2012 at 05:30 GMT

Peter--do you mean it repros in the CM in our fork? That could mean that it's a bug that was fixed in CM master already, or that we introduced it somehow (although the latter is unlikely).

core-ai-bot commented 3 years ago

Comment by peterflynn Tuesday May 15, 2012 at 06:44 GMT

Yes, that's true -- it could also be an injection from our fork's changes. But I agree that seems unlikely.

core-ai-bot commented 3 years ago

Comment by njx Wednesday Feb 13, 2013 at 01:26 GMT

No longer repros in master after cmv3 merge. FBNC@peterflynn

core-ai-bot commented 3 years ago

Comment by peterflynn Friday Feb 15, 2013 at 19:47 GMT

Confirmed, closing