search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Remove old preferences system #8676

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by le717 Friday Oct 31, 2014 at 03:09 GMT Originally opened as https://github.com/adobe/brackets/pull/9752

For #8751.

This also removes PreferencesManager.setValueAndSave(), deprecated by 08e8208e2c2bd229be4e0f11700853890a981c5f in Sprint 37. In order to prevent a repeat of Quick Open, I removed it in a separate commit in case it needs to be reverted and set my search utility to scan more thoroughly. No known extension usage was discovered.

/cc@dangoor

le717 included the following code: https://github.com/adobe/brackets/pull/9752/commits

core-ai-bot commented 3 years ago

Comment by busykai Saturday Jan 31, 2015 at 21:15 GMT

I guess it's pretty safe to remove the old preference implementation at this point. This PR is not mergeable, but before@le717 actualizes it, we need to decide.

CC@redmunds,@peterflynn

core-ai-bot commented 3 years ago

Comment by le717 Saturday Jan 31, 2015 at 21:47 GMT

@busykai The outcome of #10412 will effect this.

core-ai-bot commented 3 years ago

Comment by ficristo Monday Nov 21, 2016 at 18:23 GMT

Closing in favour of https://github.com/adobe/brackets/pull/12720 since is more up-to-date.