search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Fixing resizing performance issue in split view #8694

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by ghominejad Friday Oct 31, 2014 at 20:50 GMT Originally opened as https://github.com/adobe/brackets/pull/9772

Resizing in split view is too slow because codemirror's width is changing on resizing and it has to render it's contents every time.

We change the width to fixed size (3000px) on resizing start and restore to default at the end so codemirror doesn't render it's contents anymore :)

ghominejad included the following code: https://github.com/adobe/brackets/pull/9772/commits

core-ai-bot commented 3 years ago

Comment by Mark-Simulacrum Friday Oct 31, 2014 at 21:38 GMT

You'll need to sign the CLA (http://dev.brackets.io/brackets-contributor-license-agreement.html) to contribute code to Brackets.

core-ai-bot commented 3 years ago

Comment by RaymondLim Friday Oct 31, 2014 at 21:41 GMT

@ghominejad You need to sign the Brackets Contributor License Agreement (CLA) before we can merge your pull request. And also make sure you have checked https://github.com/adobe/brackets/wiki/Pull-Request-Checklist, especially, the Coding Style Guideline.

core-ai-bot commented 3 years ago

Comment by ghominejad Friday Oct 31, 2014 at 22:23 GMT

ok, thanks