search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] [CEF 2171] Menu bar is taller #8948

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by peterflynn Thursday Dec 04, 2014 at 07:15 GMT Originally opened as https://github.com/adobe/brackets/issues/10081

In the CEF 2171 build, there's an extra 4px of padding below the native menu bar, before the HTML UI content starts:

cef-menubar-comparison

I'm not sure how CEF could be causing this, since I thought we control the window layout outside the CEF widget itself. @JeffryBooher, any ideas?

core-ai-bot commented 3 years ago

Comment by pthiess Monday Dec 08, 2014 at 17:15 GMT

@peterflynn To me it looks like the native menu is consistent - just the html stack content looks 'scaled' - not sure if this is truly a native issue.

core-ai-bot commented 3 years ago

Comment by JeffryBooher Monday Dec 08, 2014 at 17:15 GMT

@peterflynn this almost looks some css is being applied to the body tag. have you tried reloading without extensions? it also looks like (in addition to padding) that there is a letter-spacing property being applied

core-ai-bot commented 3 years ago

Comment by peterflynn Monday Dec 08, 2014 at 20:40 GMT

@JeffryBooher It's easy to confirm with dev tools that this is not the case -- the entire HTML content stops where the top border of the editor is seen. Everything above that is native UI. (Also, there's no element in our DOM that is dark gray like that and spans the full width of the page, so padding wouldn't cause that color to appear anyway). And yes, happens even with extensions disabled. It's not UTR on your end, is it?

core-ai-bot commented 3 years ago

Comment by peterflynn Monday Dec 08, 2014 at 20:42 GMT

@pthiess No, the UI isn't being rescaled. The changes in the text width you're seeing there are #10083. But the text height, padding, etc. are unchanged.

core-ai-bot commented 3 years ago

Comment by JeffryBooher Monday Dec 08, 2014 at 21:16 GMT

@peterflynn how are you able to get that screen grab? is this something happening later after brackets has loaded or is this a comparison of 1547 and 2171?

core-ai-bot commented 3 years ago

Comment by peterflynn Monday Dec 08, 2014 at 22:10 GMT

@JeffryBooher It's comparing 1547 & 2171

core-ai-bot commented 3 years ago

Comment by JeffryBooher Monday Dec 08, 2014 at 22:35 GMT

@peterflynn are you sure you're comparing this against 1.0? We made quite a number of changes to the shell to accommodate auto-hide task bars just before 1.0 shipped.

Here's what I see between 1.0 and 1.1

image

The top border padding is virtually identical but it has changed since the Release 38/39 builds.

core-ai-bot commented 3 years ago

Comment by JeffryBooher Monday Dec 08, 2014 at 22:38 GMT

BTW, The left image is 1.0 (CEF 1547) the right image is 1.1 (CEF 2171)

core-ai-bot commented 3 years ago

Comment by JeffryBooher Monday Dec 08, 2014 at 22:39 GMT

Let me know if that's not what you're seeing -- that would be scary if you don't.

core-ai-bot commented 3 years ago

Comment by JeffryBooher Tuesday Dec 09, 2014 at 18:00 GMT

Closing as by design.