search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] .cm-error styles get applied to browser-prefixed CSS properties #9000

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by luboslives Thursday Dec 11, 2014 at 18:08 GMT Originally opened as https://github.com/adobe/brackets/issues/10149

While creating my own theme for Brackets, I noticed that browser-prefixed CSS properties such as -webkit-max-device-pixel-ratio end up displaying everything after -webkit- as error text (in the colour assigned to .cm-error).

Maybe we need a new class added to Themes, or .cm-error needs some sort of added specificity.

core-ai-bot commented 3 years ago

Comment by JeffryBooher Friday Dec 12, 2014 at 22:36 GMT

@luboslives I'm pretty sure the tag parser is just stripping off the -webkit- prefix and erroring on the fact that max-device-pixel-ratio isn't a defined property for the CSS hints property list. You can fix this by adding max-device-pixel-ration to CSSProperties.json but we typically don't add them until they are adopted by the W3C.

Point of reference, -webkit-animation doesn't display in the error color because animation is a defined property in CSSProperties.json.

core-ai-bot commented 3 years ago

Comment by luboslives Saturday Dec 13, 2014 at 06:19 GMT

Thanks@JeffryBooher, makes sense. Maybe I'll make a note of this whenever I decide to upload my theme.