search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Windows Hi DPI support requires a settings change by the user? #9023

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by jasonsanjose Monday Dec 15, 2014 at 21:19 GMT Originally opened as https://github.com/adobe/brackets/issues/10178

I'm running 1.1.0-15542 on Win 8 on a Samsing Ativ Book 9 (3200 x 1800) with the display set at 200%. On the left is Brackets 1.1 out of the box, on the right is Brackets with the "Disable display scaling on high DPI settings" checkbox enabled.

Notice with the setting disabled...

windows hi dpi

Do we expect users to do this manually or should it be automatically detected? References:

http://www.magpcss.org/ceforum/viewtopic.php?f=6&t=12366 http://msdn.microsoft.com/en-us/library/windows/desktop/dn469266%28v=vs.85%29.aspx https://code.google.com/p/chromiumembedded/issues/detail?id=1445

core-ai-bot commented 3 years ago

Comment by JeffryBooher Monday Dec 15, 2014 at 22:53 GMT

@jasonsanjose the itty-bity-icons are were never tested with HiDPI so this will need to be fixed. @larz0 we'll need new icons for Rretina, err, Hi DPI Windows displays :)

We should enable HiDPI by default by adding hi dpi aware information to the application manifest.

@pthiess Should we task out the work to be done on this card https://trello.com/c/WRhZ0xvj or a new github story card? It sounds like there are a few bugs and cleanup items before we can say Windows is 100% hi dpi; plus the card references Linux which is still yet to be supported.

core-ai-bot commented 3 years ago

Comment by larz0 Tuesday Dec 16, 2014 at 22:45 GMT

Made a PR for new HiDPI icons: https://github.com/adobe/brackets-shell/pull/494

core-ai-bot commented 3 years ago

Comment by pthiess Monday Jan 05, 2015 at 19:52 GMT

@ryanstewart We need your input on this team nomination.

core-ai-bot commented 3 years ago

Comment by peterflynn Sunday Jan 18, 2015 at 10:15 GMT

In review last week we talked about splitting this into two pieces:

  1. Change the manifest only, so the setting change isn't required.
  2. Update the custom window chrome so the minimize/maximize/restore icons are drawn & position at the correct size (instead of tiny as in screenshot above).

The benefit seems big enough that it might be worth getting part 1 merged sooner -- the idea is that people would be ok living with the tiny window-size icons until part 2 lands later, in exchange for getting automatic high DPI support sooner. @JeffryBooher I think you were going to post an estimate of how much work it is do to just the manifest change?

core-ai-bot commented 3 years ago

Comment by JeffryBooher Sunday Jan 18, 2015 at 18:18 GMT

@peterflynn sorry, I thought I mentioned that this work would take only a day to add and test during the meeting. Either we add a manifest file since there isn't one and add the setting

<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0" xmlns:asmv3="urn:schemas-microsoft-com:asm.v3" >
  <asmv3:application>
    <asmv3:windowsSettings xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">
      <dpiAware>true</dpiAware>
    </asmv3:windowsSettings>
  </asmv3:application>
</assembly>

or we can just call SetProcessDpiAwareness(true); on startup -- which seems easier since we don't need to worry about adding a manifest file to the repo and that change would require changing the grunt script as well...

core-ai-bot commented 3 years ago

Comment by peterflynn Monday Jan 19, 2015 at 05:14 GMT

@JeffryBooher Oh cool, ok! I'm going to nominate this for 1.2 then, since it seems relatively manageable to get that first half in...

core-ai-bot commented 3 years ago

Comment by nethip Thursday Feb 05, 2015 at 09:13 GMT

Initial implementation done. Needs rigorous testing on all platforms. Moving this to 1.3

core-ai-bot commented 3 years ago

Comment by jasonsanjose Wednesday Feb 11, 2015 at 16:20 GMT

@nethip It looks like this landed in the 1.2 release branch in brackets-shell. Is that what you intended?

core-ai-bot commented 3 years ago

Comment by nethip Wednesday Feb 11, 2015 at 16:27 GMT

@jasonsanjose Yes indeed :smile: I am closing this bug.

core-ai-bot commented 3 years ago

Comment by MarcelGerber Friday Feb 13, 2015 at 18:31 GMT

@nethip@jasonsanjose Either one of you should set the milestone of this issue back to 1.2 if it gets shipped with 1.2

core-ai-bot commented 3 years ago

Comment by nethip Friday Feb 13, 2015 at 19:27 GMT

@MarcelGerber Thanks! Changed it to Release 1.2