search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Cleaner fix for LiveDevMultiBrowser infinite loop #9046

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by peterflynn Wednesday Dec 17, 2014 at 18:44 GMT Originally opened as https://github.com/adobe/brackets/pull/10207

This is for #10193. See discussion here for context: https://github.com/adobe/brackets/pull/10192#discussion_r21957109.

Move shared code into FileUtils (with unit tests) to minimize diff in the _getInitialDocFromCurrent() code that is duplicated between the two Live Preview impls.

Also...

peterflynn included the following code: https://github.com/adobe/brackets/pull/10207/commits

core-ai-bot commented 3 years ago

Comment by busykai Wednesday Dec 17, 2014 at 18:56 GMT

LGTM, just the comment on the function name and nit on the suite name.

core-ai-bot commented 3 years ago

Comment by dsrw Wednesday Dec 17, 2014 at 19:03 GMT

Works for me. Thanks a lot@peterflynn and@busykai. I'll close my PR.

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Dec 17, 2014 at 19:09 GMT

@busykai Oops, sorry -- somehow I accidentally pushed a draft that didn't have my final changes committed. The actual changes in my real commit (should be up there now) doesn't have either of the issues you mentioned. (I used the API name getParentPath() to stay analogous with FleSystemEntry.parentPath, as well as to indicate a string return value as you mentioned).

core-ai-bot commented 3 years ago

Comment by busykai Wednesday Dec 17, 2014 at 19:11 GMT

@peterflynn, thanks! This looks good to me. Just some manual testing and will merge it. The tests are clean.

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Dec 17, 2014 at 19:11 GMT

Excellent, thanks!

core-ai-bot commented 3 years ago

Comment by busykai Wednesday Dec 17, 2014 at 19:20 GMT

Merging.