search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Renaming folder breaks file selection #9296

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by njx Thursday Feb 05, 2015 at 18:10 GMT Originally opened as https://github.com/adobe/brackets/issues/10527

  1. Create a new project
  2. Create a file "file.js" at the top level
  3. Create a folder "folder" at the top level
  4. Create a file "file-in-folder.js" inside "folder"
  5. Select "file-in-folder.js" in the file tree (not the working set)
  6. Rename "folder" to something else
  7. Try to select "file.js" in the file tree

Result: The filename turns blue but does not get the background highlight. Clicking back and forth between file-and-folder.js and file.js in the file tree causes inconsistent state (the correct document doesn't open in the editor and sometimes the filename goes into rename mode).

core-ai-bot commented 3 years ago

Comment by njx Thursday Feb 05, 2015 at 18:10 GMT

This seems important to fix - it pretty much breaks the file tree until you switch projects.

core-ai-bot commented 3 years ago

Comment by ryanstewart Thursday Feb 05, 2015 at 18:23 GMT

@madanbn Do you think we can mark this for 1.2 and get a fix in?

core-ai-bot commented 3 years ago

Comment by RaymondLim Thursday Feb 05, 2015 at 18:48 GMT

@njx I can't reproduce it on my Mac 10.9.

core-ai-bot commented 3 years ago

Comment by redmunds Thursday Feb 05, 2015 at 19:17 GMT

I'm not seeing it either in latest master on 10.10.2 .

core-ai-bot commented 3 years ago

Comment by njx Thursday Feb 05, 2015 at 23:19 GMT

Let me pull master - this was in 10.1 release.

core-ai-bot commented 3 years ago

Comment by njx Thursday Feb 05, 2015 at 23:25 GMT

I can reproduce it in master with a slightly altered set of steps. Updated above.

core-ai-bot commented 3 years ago

Comment by RaymondLim Thursday Feb 05, 2015 at 23:44 GMT

Yes, now I can reproduce it with the updated steps even in release 44.

core-ai-bot commented 3 years ago

Comment by njx Friday Feb 06, 2015 at 18:23 GMT

I put up a possible fix in #10541, but there are other issues that someone more familiar with the file tree code should probably address - see the comment in that PR.

core-ai-bot commented 3 years ago

Comment by peterflynn Wednesday Feb 11, 2015 at 01:48 GMT

There's a separate bug with the view panes if you follow these steps and then reselect "file-in-folder.js" again (see https://github.com/adobe/brackets/pull/10541#issuecomment-73821322), but the tree bug is fixed -- closing.