search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Update CodeMirror #9599

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by ryanstewart Friday Apr 17, 2015 at 08:21 GMT Originally opened as https://github.com/adobe/brackets/issues/10921

Update code mirror to latest version and fix issues.

core-ai-bot commented 3 years ago

Comment by MarcelGerber Friday May 08, 2015 at 15:00 GMT

I'd like to take this, as well as trying to fix the unit test failures you stated. Is that ok?

core-ai-bot commented 3 years ago

Comment by nethip Saturday May 09, 2015 at 10:05 GMT

@MarcelGerber Sure go ahead and continue with the tasks. We were half way through the fixes.@prafulVaishnav Could you chime in here with the SASS issues you were facing when try to update CM to latest version.

core-ai-bot commented 3 years ago

Comment by MarcelGerber Saturday May 09, 2015 at 10:10 GMT

I wonder what fixes you're talking about? For me, one fix (see #11071) sufficed to make everything work as expected. What other issues were you running into?

Are the SASS issues you mentioned related to the CSS Parsing unit test? I've fixed that issue.

core-ai-bot commented 3 years ago

Comment by nethip Saturday May 09, 2015 at 10:34 GMT

It could be them but I am not sure as@prafulVaishnav is the one who is actively looking into it.