search

brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Scrolling sometimes reverts to being too fast #9711

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by thany Monday May 11, 2015 at 12:44 GMT Originally opened as https://github.com/adobe/brackets/issues/11083

The scrolling-too-fast-bug seems to have been resolved... To a certain point. I can't put my finger on it, but at some point it reverts to scrolling too fast again. It almost looks like there's some kind of built-in scrolling acceleration going on (like how OSX very annoyingly has, but to a lesser degree).

But right now, as I write this, the file tree is scrolling 18 lines per tick. That is still waaay too fast. The main editor scrolls 22-ish lines per tick. Also waaaaay too fast. If I restart Brackets... (doing it now)... It's back to normal again.

Windows 7 x64, Brackets 1.3. No mouse software installed, default drivers and all that. No scrolling modifiers like KatMouse, nothing like that.

core-ai-bot commented 3 years ago

Comment by thany Monday May 11, 2015 at 16:12 GMT

Update: yeah it literally happens out of the blue. I don't need to do anything in order the scrolling speed to mess up again. It can happen literally anytime. It's like a ticking timebomb without display.

I'm very curious to know why this is happening. My programming skills from way back tell me that this shouldn't be too hard, but then again, brackets depends on a fairly great number of 3rd party components, which might explain how this is so difficult to tackle...

core-ai-bot commented 3 years ago

Comment by thany Tuesday May 12, 2015 at 09:07 GMT

Update 2: the scrolling may speed up even moments after reloading Brackets, and literally only just scrolling. So I reload, scroll some, and boom.

I'll have to revert to 1.0 for the moment. I can't work like this.

Please bear in mind, Brackets 1.2 behaviour was better actually. That one was way too fast, but at least consistenly so, and therefor workaroundable with KatMouse. This is why I can't use 1.3 for the moment. But then, older versions cause other problems. See why I'm annoyed?

core-ai-bot commented 3 years ago

Comment by MarcelGerber Tuesday May 12, 2015 at 17:27 GMT

You can see what we did to fix this bug here: https://github.com/adobe/brackets/pull/10930 It's a hack, I know, but it at least works.

What extensions do you have installed? Maybe one of them calls body.removeEventListener? (If you give me a list of the extensions you have installed, I could look that up)

core-ai-bot commented 3 years ago

Comment by thany Wednesday May 13, 2015 at 08:19 GMT

For the moment, I've got these installed:

brackets-display-shortcuts
brackets-morecsscodehints
brackets-oncopy
brackets-various-improvements
camden.jshint
de.richter.brackets.jsonlint
gruehle.markdown-preview
html-block-selector
io.brackets.svg-code-hints
ivogabe.icons
jeffbooher.bookmarks
laron.liquid
mikaeljorhult.brackets-todo
pflynn.charcount
pflynn.svg.preview
soft-dark
talmand.disable-autoclose-tags
torin.duplicate
core-ai-bot commented 3 years ago

Comment by MarcelGerber Wednesday May 13, 2015 at 12:10 GMT

If it happens again, could you follow these steps:

  1. Open the developer tools (Debug > Show Developer Tools or F12)
  2. Make sure you're in the Elements view (first tab)
  3. Click the <body> tag
  4. On the right, switch over to the Event Listeners tab
  5. Expand the wheel section (if there is one), which should look like this: image

Does it look like this or not? Are there any other handlers listed under wheel? It would be very helpful to see whether it's just the handler being removed or the handler code failing.

core-ai-bot commented 3 years ago

Comment by thany Wednesday May 13, 2015 at 15:16 GMT

After the scrolling speed has increased again, the handler is exactly as in your screenshot. Down to the line number even. It's also the only handler for wheel.

In the mean time, I've also figured out how to cause this issue, and how to make it go away: simply scroll a LOT. I mean vigorously. I have a Logitech M500 mouse with "tickless scrolling mode", where the scrollwheel becomes a flywheel. That definately triggers and un-triggers the issue. It's not neccesary to cause the issue - I just use it to repro it with absolute certainty. Scrolling more slowly will still trigger the problem, but less reliably.

I can cause the same triggering and un-triggering without any extensions loaded.

core-ai-bot commented 3 years ago

Comment by thany Wednesday May 13, 2015 at 15:28 GMT

Another update.

I've put a console.log at the point where a scroll event should get canceled. As long as the scroll speed is broken, every other scroll event does get canceled properly. The different between "good" and "bad" scrolling speed is, repsectively, the wheelDelta being either +/-120 or +/-480.

That tells me there's something else, hidden more deeply within CEF (or something else) that increases the scrolling speed. It may also explain why some people reported much higher scrolling speeds than I did in my original issue about it.

Is there a way to force wheelDelta to +/- 120 all the time? Not sure if that would fix it, but for me at least, that seems like the correct delta for one tick.

core-ai-bot commented 3 years ago

Comment by MarcelGerber Wednesday May 13, 2015 at 18:54 GMT

It would probably be quite easy to convert my PR #10685 to an extension you could utilize. It got some criticism on that it may make scrolling performance worse, though, and it only applies to the editor, not to dialogs, sidebars, panels and so on.

core-ai-bot commented 3 years ago

Comment by thany Thursday May 14, 2015 at 11:40 GMT

Not so sure about that last bit. This problem (and your solution) affects the file tree as well... After all, the handler is on the body, so shouldn't that affect the whole app?

core-ai-bot commented 3 years ago

Comment by MarcelGerber Thursday May 14, 2015 at 11:45 GMT

Yeah, my solution for the overall problem (scroll events being fired twice) affects the whole app. But one solution to the problem you now face, converting PR #10685 to an extension, would only apply to the editor.

core-ai-bot commented 3 years ago

Comment by thany Monday May 18, 2015 at 12:09 GMT

Here's my extension that works around this thing. https://github.com/thany/brackets-scrollfix

I had to replace your code to "ignore every other event" because the two were conflicting, and there's no way to remove an event listener that I can't access the handler for. That's why I'm basically also ignoring the new preference that controls it. I know it's evil, but so is this bug.

Now I can finally get back to work :)

core-ai-bot commented 3 years ago

Comment by MarcelGerber Tuesday May 19, 2015 at 19:04 GMT

As long as it works ... ;)

Notice though that this fix will go away at some point, and remember to then also uninstall your extension so you don't get a wonky scroll experience.

core-ai-bot commented 3 years ago

Comment by MarcelGerber Tuesday May 19, 2015 at 19:05 GMT

(I'm going to leave this issue open as it's still an issue that can probably be fixed by a CEF upgrade, even though you're possibly the only one who hits it)

core-ai-bot commented 3 years ago

Comment by drozzy Tuesday Aug 25, 2015 at 04:48 GMT

Sigh... I am having this issue. I got here after jumping through 3 other bugs... This is the first editor I had this ... rather bizarre, problem! It scrolls fine for 3 lines, but then it starts scrolling 12 lines at a time!

core-ai-bot commented 3 years ago

Comment by doppl3r Tuesday Aug 25, 2015 at 23:23 GMT

Same, except now I'm getting 20 line jumps (win10). "Shift + f5" is the only thing that keeps it from scroll-hopping :c

core-ai-bot commented 3 years ago

Comment by danvim Sunday Aug 30, 2015 at 08:02 GMT

Here are some details I've gathered

Here are the results from my scrolling:

Sometimes ~7 lines with a scroll (A)
Sometimes ~20 lines with a scroll (B)

How to reproduce:

Open Brackets with a long document
Scroll down and observe. You will get either (A) or (B)
Spam scrolling up and down.
For a chance, you will be switched to the other (A) -> (B) or (B) -> (A)

Also, the chrome development tool is also scrolling way too fast.

core-ai-bot commented 3 years ago

Comment by MarcelGerber Sunday Aug 30, 2015 at 08:56 GMT

Unfortunately, we can't do anything about the Chrome DevTools. PR #11638 should fix the overall problem, though.

core-ai-bot commented 3 years ago

Comment by thany Monday Aug 31, 2015 at 07:47 GMT

As far as I know, that PR should fix not just the editor, but the entire application. Same as my own (much cruder) workaround.

core-ai-bot commented 3 years ago

Comment by MarcelGerber Monday Aug 31, 2015 at 09:20 GMT

Yes, it fixes Brackets as a whole (this includes: editor, Extension Manager, file tree, ...), but as the Dev Tools are completely controlled by Chrome, we can't inject any extra JavaScript in there.

core-ai-bot commented 3 years ago

Comment by nethip Monday Aug 31, 2015 at 09:39 GMT

This seems to have been fixed in CEF upstream. https://bitbucket.org/chromiumembedded/cef/commits/7d01f373fbc8465e6d68def4153ffd15a8ef3438. We will have to wait until the next CEF integration. Until then the workaround hack made by@MarcelGerber is our best bet.

core-ai-bot commented 3 years ago

Comment by thany Tuesday Oct 27, 2015 at 17:20 GMT

I don't quite understand why this issue has been closed, and hasn't been fixed in 1.5.0. Can someone explain why this issue still exists?

core-ai-bot commented 3 years ago

Comment by danvim Wednesday Oct 28, 2015 at 13:10 GMT

@thany Maybe because they've made a to-do list to work for?

core-ai-bot commented 3 years ago

Comment by thany Wednesday Oct 28, 2015 at 16:04 GMT

If that's the case, then that list seems to greatly suffer from unbalanced priority. Not only because this is such an obvious and irritating issue, but also because it's existed for FAR too long (since version 1.1), and other OS-specific issues are still being solved without much delay at all.

core-ai-bot commented 3 years ago

Comment by danvim Sunday Nov 01, 2015 at 12:49 GMT

@thany And clicking into the todo list, it seems they are fixing the "scrolling speed too slow" problem? What the?

core-ai-bot commented 3 years ago

Comment by thany Monday Nov 02, 2015 at 12:12 GMT

Even so, looking at this issue, I still think priorities and urgency of issues is unbalanced.

core-ai-bot commented 3 years ago

Comment by thany Wednesday Jan 20, 2016 at 19:06 GMT

Is this issue finally fixed in 1.6? And if not, care to explain why?

core-ai-bot commented 3 years ago

Comment by danvim Thursday Jan 21, 2016 at 05:50 GMT

@thany Surprisingly, I haven't got the scrolling problem since I don't know when. :O

core-ai-bot commented 3 years ago

Comment by thany Thursday Jan 21, 2016 at 09:40 GMT

Perhaps because you forgot you installed an extension that works around the problem, like I have? :)

core-ai-bot commented 3 years ago

Comment by Smiley43210 Sunday Mar 27, 2016 at 02:09 GMT

This issue still appears to be present in 1.6.

core-ai-bot commented 3 years ago

Comment by thany Wednesday May 04, 2016 at 23:51 GMT

Any update on a fix, after so many moons of no fix?