brackets-archive / bracketsIssues

Archive of issues in brackets.
0 stars 0 forks source link

[CLOSED] Add Droid Sans Mono for rendering Unicode (Greek, Cyrillic) #9759

Open core-ai-bot opened 3 years ago

core-ai-bot commented 3 years ago

Issue by MarcelGerber Saturday May 23, 2015 at 12:34 GMT Originally opened as https://github.com/adobe/brackets/pull/11156


Including this font will make #3465 way better.

Why I chose Droid Sans Mono:

Google Fonts page, Typecast Demo

Screenshots: With Greek text, mixed with normal HTML: image (Demo text: Ατ σιθ σαυσαε φοσιβυς τινσιδυνθ, πρι ιν μαγνα θεμπορ δετερρυισεθ. Ιν κυι κυανδο ωμιτθαμ, εα μεα θαμκυαμ εφφισιενδι. Ειυς κυανδο κυαεκυε ιδ εσθ, σωνσυλ απειριαν δυο ιδ. Φελ φοσεντ κυαερενδυμ αδ. Νονυμες ρεπρεχενδυντ ει μεα.)

With Cyrillic text, mixed with normal HTML: image (Demo text: Ючю амэт долорэж эи, экз дикунт мэнандря трактатоз кюм. Экз жят доминг маиорюм. Мюнырэ жямиляквюы эффякиантур векж йн. Ед орнатюс ныкэжчятатябюз векж, ыам ты одео факёльиси адолэжкэнс. Шапэрэт позтюлант векж но.)

As better support for Greek/Cyrillic text is often-requested, I think this is a good undertaking.


MarcelGerber included the following code: https://github.com/adobe/brackets/pull/11156/commits

core-ai-bot commented 3 years ago

Comment by abose Saturday May 23, 2015 at 18:54 GMT


The font would come into play only if source-sans-pro doesn't have gliffs for the particular unicode text right?

core-ai-bot commented 3 years ago

Comment by abose Saturday May 23, 2015 at 18:59 GMT


I think we should consider Greek,Crillic font issue this release as we have seen a lot of issues in this area; and considering the fact that we have a substantial user base from Russia. marking this for 1.4.

core-ai-bot commented 3 years ago

Comment by MarcelGerber Saturday May 23, 2015 at 20:01 GMT


Yep, all latin text is still displayed with SourceCodePro.

This would go well together with #8985, which improves Greek/Cyrillic support for the non-editor UI. Maybe we can mark it 1.4, too?

core-ai-bot commented 3 years ago

Comment by abose Saturday May 23, 2015 at 20:14 GMT


These two could go independently; but Lets target that too for completeness :+1:

core-ai-bot commented 3 years ago

Comment by abose Thursday May 28, 2015 at 06:43 GMT


Update on this: Adobe's type team has informed me that they are extending source code pro to include Greek/Cyrillic support as required by brackets. @MarcelGerber Do you find any other issues that need to be addressed in source code pro ?

core-ai-bot commented 3 years ago

Comment by abose Thursday May 28, 2015 at 08:09 GMT


https://github.com/adobe-fonts/source-code-pro/issues/48#issuecomment-66559989

core-ai-bot commented 3 years ago

Comment by MarcelGerber Friday May 29, 2015 at 20:07 GMT


Is there any ETA on the release? I mean, the comment you linked too is from last December and yet, there's still no release (and the files are apparently not even uploaded to GitHub yet).

I really don't know whether we need other character sets as well. There are obviously many characters Source Code Pro doesn't support (I haven't specifically looked for them, but probably Arabic, Hebrew, Persian, ...), but I don't know how bad they look without font support.

core-ai-bot commented 3 years ago

Comment by abose Saturday May 30, 2015 at 09:50 GMT


I had a discussion with the fonts group at adobe and this is what i got from them:

  1. brackets font set has MS Gothic (a Japanese font) in both its localized and English name forms in our fallback set – but MS Gothic is not available for bundling, so we’re counting on it being present on the local device. The fonts team suggested integrating the Source Han Sans family . Like Source Sans it’s targeted at on-screen text, and would harmonize well with Source Code and remove this dependency on local fonts. Unlike MS Gothic, it could provide support for not only Japanese but also Korean and both forms of Chinese. We are in discussion to get these fonts too ". Adobe fonts would deliver source hans font if we are to go ahead with that.
  2. reg source code pro: "The Greek & Cyrillic extensions are in beta condition, and we think it would be ideal for Brackets to incorporate these, give us any feedback you may have, and swap in the final versions when the fonts reach GM."
  3. Also they said this the open source version of Droid Sans Mono only includes a basic Latin character set. The expanded character set which include Cyrillic and Greek (Droid Sans Mono WGL, http://www.fonts.com/font/ascender/droid-sans-mono) is only available as a commercial license -- and therefore cannot be bundled in Adobe software, and certainly not in open source software.
core-ai-bot commented 3 years ago

Comment by MarcelGerber Saturday May 30, 2015 at 10:54 GMT


That sounds great! I didn't know fonts had beta phases... The more you know :smile:

Regarding MS Gothic/MS ゴシック, though: That's the font that currently renders our Cyrillic/Greek text, but it has big letter spacing and is by no means monospace (see this screenshot).

That thing about Droid Sans Mono is strange. I got my copy - with Cyrillic/Greek support - from https://www.google.com/fonts/specimen/Droid+Sans+Mono, where they explicitly state it's under the Apache License 2.0.

core-ai-bot commented 3 years ago

Comment by abose Saturday May 30, 2015 at 14:18 GMT


:) i too saw the apache license thing;. I'll keep this thread updated.

core-ai-bot commented 3 years ago

Comment by abose Tuesday Jun 23, 2015 at 09:28 GMT


@MarcelGerber I have added the latest fonts in this PR #11301 .

core-ai-bot commented 3 years ago

Comment by MarcelGerber Tuesday Jun 23, 2015 at 16:19 GMT


Closing in favor of #11301.