Open core-ai-bot opened 3 years ago
Comment by abose Saturday May 23, 2015 at 18:54 GMT
The font would come into play only if source-sans-pro
doesn't have gliffs for the particular unicode text right?
Comment by abose Saturday May 23, 2015 at 18:59 GMT
I think we should consider Greek,Crillic font issue this release as we have seen a lot of issues in this area; and considering the fact that we have a substantial user base from Russia. marking this for 1.4.
Comment by MarcelGerber Saturday May 23, 2015 at 20:01 GMT
Yep, all latin text is still displayed with SourceCodePro.
This would go well together with #8985, which improves Greek/Cyrillic support for the non-editor UI. Maybe we can mark it 1.4, too?
Comment by abose Saturday May 23, 2015 at 20:14 GMT
These two could go independently; but Lets target that too for completeness :+1:
Comment by abose Thursday May 28, 2015 at 06:43 GMT
Update on this: Adobe's type team has informed me that they are extending source code pro to include Greek/Cyrillic support as required by brackets.
@
MarcelGerber Do you find any other issues that need to be addressed in source code pro
?
Comment by abose Thursday May 28, 2015 at 08:09 GMT
https://github.com/adobe-fonts/source-code-pro/issues/48#issuecomment-66559989
Comment by MarcelGerber Friday May 29, 2015 at 20:07 GMT
Is there any ETA on the release? I mean, the comment you linked too is from last December and yet, there's still no release (and the files are apparently not even uploaded to GitHub yet).
I really don't know whether we need other character sets as well. There are obviously many characters Source Code Pro doesn't support (I haven't specifically looked for them, but probably Arabic, Hebrew, Persian, ...), but I don't know how bad they look without font support.
Comment by abose Saturday May 30, 2015 at 09:50 GMT
I had a discussion with the fonts group at adobe and this is what i got from them:
Comment by MarcelGerber Saturday May 30, 2015 at 10:54 GMT
That sounds great! I didn't know fonts had beta phases... The more you know :smile:
Regarding MS Gothic/MS ゴシック
, though:
That's the font that currently renders our Cyrillic/Greek text, but it has big letter spacing and is by no means monospace (see this screenshot).
That thing about Droid Sans Mono is strange. I got my copy - with Cyrillic/Greek support - from https://www.google.com/fonts/specimen/Droid+Sans+Mono, where they explicitly state it's under the Apache License 2.0.
Comment by abose Saturday May 30, 2015 at 14:18 GMT
:) i too saw the apache license thing;. I'll keep this thread updated.
Comment by abose Tuesday Jun 23, 2015 at 09:28 GMT
@
MarcelGerber I have added the latest fonts in this PR #11301 .
Issue by MarcelGerber Saturday May 23, 2015 at 12:34 GMT Originally opened as https://github.com/adobe/brackets/pull/11156
Including this font will make #3465 way better.
Why I chose Droid Sans Mono:
SourceCodePro-Medium
has (from what I can tell)Google Fonts page, Typecast Demo
Screenshots: With Greek text, mixed with normal HTML: (Demo text:
Ατ σιθ σαυσαε φοσιβυς τινσιδυνθ, πρι ιν μαγνα θεμπορ δετερρυισεθ. Ιν κυι κυανδο ωμιτθαμ, εα μεα θαμκυαμ εφφισιενδι. Ειυς κυανδο κυαεκυε ιδ εσθ, σωνσυλ απειριαν δυο ιδ. Φελ φοσεντ κυαερενδυμ αδ. Νονυμες ρεπρεχενδυντ ει μεα.
)With Cyrillic text, mixed with normal HTML: (Demo text:
Ючю амэт долорэж эи, экз дикунт мэнандря трактатоз кюм. Экз жят доминг маиорюм. Мюнырэ жямиляквюы эффякиантур векж йн. Ед орнатюс ныкэжчятатябюз векж, ыам ты одео факёльиси адолэжкэнс. Шапэрэт позтюлант векж но.
)As better support for Greek/Cyrillic text is often-requested, I think this is a good undertaking.
MarcelGerber included the following code: https://github.com/adobe/brackets/pull/11156/commits