search

brackets-cont / contributor-license-agreement

This repository contains public records of everyone who can contribute and make code changes to Brackets Editor. If you wish to submit changes to repos under Brackets, please sign the CLA.
Other
1 stars 10 forks source link

Update personal_contributor_licence_agreement.md #32

Closed 9t8 closed 1 year ago

welcome[bot] commented 1 year ago

Thanks for opening this pull request to sign the CLA!.

brackets-io commented 1 year ago

Line Format Error: The expected line should be: | full name | git-username | dd-month-yyyy |

Date Error: The expected line should be: | full name | git-username | dd-month-yyyy | Invalid date: Date should be within one week of <today's date in dd-month-YYYY format> Error: 9t8 has already signed the personal contributor license agreement.

abose commented 1 year ago

Hi @9t8, Thanks for signing the CLS. There appears to be an error: Please change to: | David L | [9t8](https://github.com/9t8) | 10 January 2023 |

instead of

David L | [9t8](https://github.com/9t8) | 10 January 2023

brackets-io commented 1 year ago

Error: The pull request should have only a single commit.

    Please squash all your commits and update this pull request.
    more help: https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git

Line Format Error: The expected line should be: | full name | git-username | dd-month-yyyy |

Date Error: The expected line should be: | full name | git-username | dd-month-yyyy | Invalid date: Date should be within one week of <today's date in dd-month-YYYY format> Error: 9t8 has already signed the personal contributor license agreement.

abose commented 1 year ago

Hi @9t8, The checks fail as quotes are missing from the name. sorry for missing that in the earlier exaple.

| `David L` | [9t8](https://github.com/9t8) | 10 January 2023 |

notice the ` missing in | `David L` |
welcome[bot] commented 1 year ago

Congrats on merging your first pull request! Welcome to Brackets Community (brackets.io).

brackets-io commented 1 year ago

Error: The pull request should have only a single commit.

    Please squash all your commits and update this pull request.
    more help: https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git

Line Format Error: The expected line should be: | full name | git-username | dd-month-yyyy |

Date Error: The expected line should be: | full name | git-username | dd-month-yyyy | Invalid date: Date should be within one week of <today's date in dd-month-YYYY format> Error: 9t8 has already signed the personal contributor license agreement.

abose commented 1 year ago

Thanks, @9t8 for signing the CLA and helping with brackets development.