Reenable integration tests

brackets-userland / brackets-electron

An open source code editor for the web, written in JavaScript, HTML and CSS.

http://brackets.io

MIT License

81 stars 8 forks source link

Reenable integration tests #100

Closed ficristo closed 6 years ago

ficristo commented 6 years ago

I used the nativeWindowOpen option available in electron 1.7 I set the menu for each window. Before, when a window was created, the menu was added again and in every window. On macOS the menu is shared, so win.setMenu does nothing. So I used Menu.setApplicationMenu which seemed to work ok(ish).

To merge it needs:

[ ] verify macOS
[ ] merge https://github.com/brackets-userland/brackets-electron/pull/97
[ ] rebase to master

ficristo commented 6 years ago

I had some issues with shortcuts on multiple windows, but otherwise seemed to work fine. But I don't think I'll be back to this anytime soon.