search

brackets-userland / brackets-git

brackets-git — git extension for adobe/brackets
Other
656 stars 193 forks source link

Added authentication to Clone dialog #1250

Closed mattbell87 closed 8 years ago

mattbell87 commented 8 years ago

Fixes #707 and #1018

I added a new modal dialog js file and template for cloning. Closely based it on the Pull and Push dialogs in terms of code, but still looks familiar to the original Utils.askQuestion that handled cloning.

I replaced the Utils.askQuestion code with the new modal dialog in NoRepo.js. I looked at the Push/Pull code from Remotes.js and used the same methods and style. I removed the strings require as it's now handled in the modal dialog.

Added 1 line in the LESS file (just the ID of the modal) so that the input field is full length.

Linted everything with grunt jshint :). No errors or unhandled stuff.

brackets-git-clone-auth

zaggino commented 8 years ago

:+1:

zaggino commented 8 years ago

thanks for the PR, looks good

zaggino commented 8 years ago

Published this to brackets-npm-registry as 0.15.0, brackets registry seems broken again so I'll try later there.

mattbell87 commented 8 years ago

Cool thanks, I haven't tried the npm registry, might have to give it a spin!

mattbell87 commented 8 years ago

Should we merge this in to your 1.x branch as well?

zaggino commented 8 years ago

1.x is a complete rewrite, i haven't had time to work on it for a while, maybe during christmas holidays ... anyway, it wouldn't be possible to merge this into it, i'll need to reimplement it again (1.x is done in react)

mattbell87 commented 8 years ago

Ah I see no worries. I'll keep an eye on it and contribute if I can!