Add counter for commits behind

brackets-userland / brackets-git

brackets-git — git extension for adobe/brackets

Other

656 stars 193 forks source link

Add counter for commits behind #1254

Closed mattbell87 closed 8 years ago

mattbell87 commented 8 years ago

Fixes #604

Here is a summary of changes:

Changed getCommitsAhead() to getCommitCounts() - this new function gets both ahead and behind in one command, returns an object
Added refreshCommitCounts() which calls getCommitCounts(), then updates the pull and push buttons
- ~~This function calls a fetchRemote() on the current remote (some of this based off code in Remotes.js) - this is because a fetch is required to see how many commits we're behind the remote.~~ Removed this, too heavy on large repos. Manual for now.
Added a Panel include to Remotes as I need it to refresh the panel when changing remotes

Also I noticed that when running grunt jshint it didn't cover everything that Travis does (jscs as well), so I read the Gruntfile.js and discovered that Travis must be using grunt test. I linted with that and decided that Contributing.md may need to be updated. It's there in one of the commits anyway :).

I'm open to any further changes you require if need be.

mattbell87 commented 8 years ago

I've been thinking a fetch is still too heavy, even though it does get the job done. I think we should at least have an option to toggle it.

However there might be a lighter option, I've been investigating ls-remote and interpreting the output of that instead. It's not as clean of a command but if it's lighter on bandwidth it may be worth pursuing.

mattbell87 commented 8 years ago

I've removed the fetch from the commit counter. The behind counter on the pull button does work but only if you fetch using the command line and click refresh.

I had another comment here previously to do with adding a fetch button, but I think it needs to be in a separate issue / PR.

zaggino commented 8 years ago

Hi, done a bit of comments, otherwise it looks good. Let me know your thoughts. Thanks

mattbell87 commented 8 years ago

Yep all fixed and replied. Cheers.

zaggino commented 8 years ago

One last bit and I'm gonna merge this. Thanks

mattbell87 commented 8 years ago

Not a problem, all done

zaggino commented 8 years ago

Merged, thanks for the PR :+1: I'll fix the one last bit.

zaggino commented 8 years ago

I've realized that some things I've pointed out I'm actually doing too in old codes ... sorry for that, parts of brackets-git are quite old and not very well written.

mattbell87 commented 8 years ago

That's OK hahah, I had it as a standard throw new Error at one point, but then I saw some other code and took a different path lol.

zaggino commented 8 years ago

No worries, I'm face-palming myself reading some code structures I've created :)