search

brackets-userland / brackets-git

brackets-git — git extension for adobe/brackets
Other
656 stars 193 forks source link

Fix for #1272 #1273

Closed mattbell87 closed 8 years ago

mattbell87 commented 8 years ago

Proposed additional check for #1272

mattbell87 commented 8 years ago

Not sure what's going on here, it's saying 31 errors in 48 files yet I only changed 1 file.

mattbell87 commented 8 years ago

I pulled a fresh copy from your repo, npm install, grunt test and it's still saying that, something odd is going on there.

I did miss a semicolon on mine though I noticed, damn ASI. I'll put that in.

petetnt commented 8 years ago

@mattbell87 This fixed #1272 for me, no more errors.

mattbell87 commented 8 years ago

:+1:

mattbell87 commented 8 years ago

@zaggino any idea what's causing the grunt test to fail? Updated linters maybe reporting previously unreported code issues?

zaggino commented 8 years ago

@mattbell87 not failing for me:

Zaggi@CO9QUQM MINGW64 ~/AppData/Roaming/Brackets/extensions/user/zaggino.brackets-git (master)
$ grunt test
Running "jshint:files" (jshint) task
>> 48 files lint free.

Running "jscs:src" (jscs) task
>> 48 files without code style errors.

Done, without errors.
mattbell87 commented 8 years ago

Cheers! :)

Re: jshint have you tried doing npm update or npm install --force to see if it's newer stuff that's causing Travis to fail?

zaggino commented 8 years ago

Yes, doing that makes the errors show now. I'll fix them later.