brackets-userland / brackets-git

brackets-git — git extension for adobe/brackets
Other
656 stars 193 forks source link

changed position of branch button and dropdown #1277

Closed ghost closed 8 years ago

ghost commented 8 years ago

solution for issue 1081.

I think the positioning of the dropdown could be improved, but it's not the issue here.

When used together with another popular extension, the branch switcher is just occupying to much space there.

screen shot 2016-02-26 at 19 11 00

I'm not a fan of the "close files" button, but I couldn't find a better place to put it right now.

Please consider this change, as I would like to see it implemented soon.

screen shot 2016-02-26 at 19 09 39
zaggino commented 8 years ago

Nice, but please make the branch button position configurable through options, with default the current one and alternative in the bottom bar like on the screenshot.

ghost commented 8 years ago

Appart from the fact that the build is failing, I've just noticed that there is a downside to this feature. If no file is currently open, the status bar is empty. Thus, hiding the branch feature of this extension. As a contributor, I would still like to see this feature implemented. But from a user point of view, I admit that is sub optimal, when you have to open a file, just to change the branch. When I find the time I will experiment with other solutions for the overlapping problem. Maybe if the branch sits below the project's name, instead of being inline. Also, we can always propose the brackets team, a new area on the status bar, that doesn't hide it's contents when no file is open.

ghost commented 8 years ago

this pull request is to be ignored