search

brackets-userland / brackets-git

brackets-git — git extension for adobe/brackets
Other
656 stars 192 forks source link

Incorrect .gitignore interpretation #1309

Open Jiedara opened 8 years ago

Jiedara commented 8 years ago

I'm currently working on a simple WordPress. I got a .gitignore file that ignore all the WordPress files except /wp-content/themes/ & /wp-content/plugins/

There is the .gitignore (a part of it at least)

wp-content/* !wp-content/mu-plugins/ !wp-content/plugins/ !wp-content/themes/

ignore these plugins

wp-content/plugins/hello.php

ignore specific themes

wp-content/themes/twenty*/

But the brackets-git plugin got this behavior : gitignore-fail-brackets

My custom theme my-theme appear as ignored, even if it's not (I can commit my modification made in this folder, even if it seem to be ignored). Same for the index.php file at the root of the /wp-content/themes/ folder.

It seem to be a purely graphic bug, and it is not blocking at all, but it may be embarrassing. (I was actually struggling with my .gitignore file before understanding that it was correct, and the plugin was misinterpreting it...)

zaggino commented 8 years ago

This is the parsing function: https://github.com/zaggino/brackets-git/blob/3bafdb06c7b06f48e826ef2b1daeaa450c344459/src/ProjectTreeMarks.js#L46-L104

I'd be happy to review a pull request.

Jiedara commented 8 years ago

I'll think about it, but your code seem to be beyond my javascript level ...