brackets-userland / brackets-git

brackets-git — git extension for adobe/brackets
Other
656 stars 193 forks source link

Error when loading in Brackets 1.7.1.1 - missing mustache #1318

Open ldl5007 opened 7 years ago

ldl5007 commented 7 years ago

Hi, I ran into the following error after updated brackets-git. Look like mustache is missing for some reason.

ExtensionLoader.js:220 [Extension] failed to load C:/Users/lyzla01/AppData/Roaming/Brackets/extensions/user/zaggino.brackets-git - Error: Module name "thirdparty/mustache/mustache" has not been loaded yet for context: http://requirejs.org/docs/errors.html#notloadederrback @ ExtensionLoader.js:220 ExtensionLoader.js:224 Error: Module name "thirdparty/mustache/mustache" has not been loaded yet for context: http://requirejs.org/docs/errors.html#notloaded at makeError (file:///C:/Program%20Files%20(x86)/Brackets/dev/src/thirdparty/requirejs/require.js:166:17) at Object.localRequire as getModule at Object. (file:///C:/Users/lyzla01/AppData/Roaming/Brackets/extensions/user/zaggino.brackets-git/src/ErrorHandler.js:6:47) at Object.context.execCb (file:///C:/Program%20Files%20(x86)/Brackets/dev/src/thirdparty/requirejs/require.js:1658:33) at Object.Module.check (file:///C:/Program%20Files%20(x86)/Brackets/dev/src/thirdparty/requirejs/require.js:869:55) at Object. (file:///C:/Program%20Files%20(x86)/Brackets/dev/src/thirdparty/requirejs/require.js:1121:34) at file:///C:/Program%20Files%20(x86)/Brackets/dev/src/thirdparty/requirejs/require.js:132:23 at file:///C:/Program%20Files%20(x86)/Brackets/dev/src/thirdparty/requirejs/require.js:1164:21 at each (file:///C:/Program%20Files%20(x86)/Brackets/dev/src/thirdparty/requirejs/require.js:57:31) at Object.Module.emit (file:///C:/Program%20Files%20(x86)/Brackets/dev/src/thirdparty/requirejs/require.js:1163:17) 2

Regards,

zaggino commented 7 years ago

I've tried with 1.8 (https://github.com/adobe/brackets/releases) and it installs fine (restart required after install)

ldl5007 commented 7 years ago

I switched over to Brackets 1.8 (8c7f548d0) and still having the same issue with loading the extension.

I noted that the issue is from brackets.getModule("thirdparty/mustache/mustache") statement. I also noted that you switching out of using the global Mustache variable in the "Require Mustache (changed in Brackets 1.7)" commit.

For curiosity sake, I switched back to use the Mustache variable by commented out all of the "brackets.getModule("thirdparty/mustache/mustache")" usages. This allow the extension to load and run like normal for me. The console log does not show any warning related to using the global Mustache variable either.

I am suspecting my brackets environment might have been polluted and uninstall/reinstall brackets does not help.

If you have any suggestion please let me know.

Thank you,