brackets-userland / brackets-git

brackets-git — git extension for adobe/brackets
Other
657 stars 193 forks source link

hooks break committing/pushing #1345

Open johnnybubonic opened 6 years ago

johnnybubonic commented 6 years ago

When trying to use this hook to automatically render documentation, there is a VERY long delay - something like 5-10s - when the hook script should only take about 1.5s or less to run (as it does when using commandline git commands).

This delay seems to occur whether it's a pre-commit or a pre-push.

I get the following:

Error: cmd-spawn-timeout: git commit -m COMMIT_MSG_HERE

but the hook does run. However, brackets' git integration from that point on seems broken, and drastically so. if it's a pre-commit hook, the rendered files, which should be included IN the commit for pre-commit hooks, are marked as new modifications. it seems they are being staged AFTER the commit, not BEFORE (where pre-commit hooks should be indexing/staging adds.)