Restyle of edited files tab

brackets-userland / brackets-git

brackets-git — git extension for adobe/brackets

Other

656 stars 192 forks source link

Restyle of edited files tab #341

Open FezVrasta opened 10 years ago

FezVrasta commented 10 years ago

Little mockup for the restyle of the extension (specifically the git-edited files tab).

It aims to simplify the UI and remove dialog popups that are uncomfortable and awful. I've not used icons because the mockup software didn't have them, logically the finished version will have icons.

zaggino commented 10 years ago

Ok, the only real change that I see is that you got rid of commit dialog and put commit message to the panel - to which I immediately say no.

Why? It reminds me of Visual Studio, which I have to use from time to time when coding C# stuff. And before every commit I need to do extra clicks to compare the diffs and see, what I'm really committing.

How many forgotten console.log commands will you put into the commit this way? Even one is way too much.

Also how am I supposed to put together a wording for a commit message, if I don't see what is being committed?

FezVrasta commented 10 years ago

the mockup doesn't show everything, but clicking on one of the files the diff is shown

zaggino commented 10 years ago

when i click commit, will it show me the commit diff?

FezVrasta commented 10 years ago

When you click on a file in the list, commits are shown in the history tab.

zaggino commented 10 years ago

So when I'm committing 30 files I have to click 30 times?

FezVrasta commented 10 years ago

There should be an expand all button, in this way the result would be exactly like the current one but without modal dialogs.

zaggino commented 10 years ago

But I don't want to do an extra click on "expand all" before every commit.

zaggino commented 10 years ago

If you want to allow user to commit without requiring him to look at the diff first - that's a bad practice and will simply not happen in this extension.

FezVrasta commented 10 years ago

I can find a solution, let me try :) it's my job lol

zaggino commented 10 years ago

Keep trying.

Btw I have a solution how to remove the commit dialog but it'll require some Brackets hacking so if you want take a pause for a week and see what I'll come up with.

FezVrasta commented 10 years ago

What are you thinking about?

My idea would be just an auto-expand-all on focus on the input fields of the commit-box

zaggino commented 10 years ago

Fullscreen object to cover the area of the codemirror. This would give us enough space to implement nice history or side-by-side merging in the future.