Not generating 'build' on windows

[corintho]

I was trying to use it on windows, but was unsuccessful. ESLint complained about a couple problems in gulpfile (dangling comma on line 104 - removed). And registry-dialog (unused on lines 8 and 11 - used comment to override validation). After fixing those issues, the installation process was not generating the 'dist' directory.

I was able to fix it by changing a couple configurations inside gulpfile. Namely the base option for gulp.src. Not sure if it is a completely cross-platform way to solve it (seems reasonable by gulp documentation). I can submit a PR with my fixes if that's worth a shot

[zaggino]

Definitely builds well on Windows, but issue might be in a node version, which node version do you have? Less than 0.12.x?

[zaggino]

This is on my Windows 7 with io.js:

Zaggi@ZAGGI-PC ~/AppData/Roaming/Brackets/extensions/user/brackets-npm-registry (master)
$ git log -1
commit 6630eda35bb62a74fc8cfc2a31e14611cd635307
Author: Martin Zagora <zaggino@gmail.com>
Date:   Sat Mar 28 22:23:22 2015 +1100

    Version 0.1.7

Zaggi@ZAGGI-PC ~/AppData/Roaming/Brackets/extensions/user/brackets-npm-registry (master)
$ node --version
v1.6.2

Zaggi@ZAGGI-PC ~/AppData/Roaming/Brackets/extensions/user/brackets-npm-registry (master)
$ npm install
/
> brackets-npm-registry@0.1.7 install C:\Users\Zaggi\AppData\Roaming\Brackets\extensions\user\brackets-npm-registry
> gulp build

[07:53:22] Using gulpfile ~\AppData\Roaming\Brackets\extensions\user\brackets-npm-registry\gulpfile.js
[07:53:22] Starting 'babel'...
[07:53:24] Finished 'babel' after 1.55 s
[07:53:24] Starting 'build'...
[07:53:24] Finished 'build' after 23 μs

[corintho]

Windows 7, node 0.10 Although the "build" does not generate any errors, it does not generate the dist output. And after that, since the default gulp target runs eslint, I get the errors I reported above.

If I manually create the "dist" dir, it still does not generate anything inside it. I obfuscated my windows username above, but it does not contains spaces nor any weird characters.

C:\Users\<user>\AppData\Roaming\Brackets\extensions\user\brackets-npm-registry>ls
CHANGELOG.md  Procfile   app.json     main.js  node_modules  requirejs-config.json  src         styles  tmp
LICENSE       README.md  gulpfile.js  nls      package.json  server.js              strings.js  test

C:\Users\<user>\AppData\Roaming\Brackets\extensions\user\brackets-npm-registry>git log -1
commit 6630eda35bb62a74fc8cfc2a31e14611cd635307
Author: Martin Zagora <zaggino@gmail.com>
Date:   Sat Mar 28 22:23:22 2015 +1100

    Version 0.1.7

C:\Users\<user>\AppData\Roaming\Brackets\extensions\user\brackets-npm-registry>git status
On branch master
Your branch is up-to-date with 'origin/master'.

nothing to commit, working directory clean

C:\Users\<user>\AppData\Roaming\Brackets\extensions\user\brackets-npm-registry>node --version
v0.10.36

C:\Users\<user>\AppData\Roaming\Brackets\extensions\user\brackets-npm-registry>npm install

> brackets-npm-registry@0.1.7 install C:\Users\<user>\AppData\Roaming\Brackets\extensions\user\brackets-npm-registry
> gulp build

[18:23:54] Using gulpfile ~\AppData\Roaming\Brackets\extensions\user\brackets-npm-registry\gulpfile.js
[18:23:54] Starting 'babel'...
[18:23:55] Finished 'babel' after 1.08 s
[18:23:55] Starting 'build'...
[18:23:55] Finished 'build' after 12 μs

C:\Users\<user>\AppData\Roaming\Brackets\extensions\user\brackets-npm-registry>ls dist
ls: dist: No such file or directory

C:\Users\<user>\AppData\Roaming\Brackets\extensions\user\brackets-npm-registry>gulp
[18:24:12] Using gulpfile ~\AppData\Roaming\Brackets\extensions\user\brackets-npm-registry\gulpfile.js
[18:24:12] Starting 'babel'...
[18:24:12] Starting 'eslint'...
[18:24:14]
C:\Users\<user>\AppData\Roaming\Brackets\extensions\user\brackets-npm-registry\gulpfile.js
  102:32  error  Unexpected trailing comma  comma-dangle

C:\Users\<user>\AppData\Roaming\Brackets\extensions\user\brackets-npm-registry\src\ui\react-components\registry-dialog.js
   8:8  error  RegistryItem is defined but never used    no-unused-vars
  11:6  error  RegistryDialog is defined but never used  no-unused-vars

✖ 3 problems (3 errors, 0 warnings)

[18:24:14] 'eslint' errored after 2 s
[18:24:14] ESLintError in plugin 'gulp-eslint'
Message:
    Failed with 3 errors
[18:24:14] Finished 'babel' after 2.02 s

C:\Users\<user>\AppData\Roaming\Brackets\extensions\user\brackets-npm-registry>

[corintho]

If I simply change line 52 on the gulpfile to :"var task = gulp.src(globs, {base: 'src'})" the build is successful.

[zaggino]

Ok, I'll definitely investigate this, submit a PR if you wish. If not I'll make the change myself. I've already fixed the ESLint errors.

[corintho]

It is literally what I showed above. Honestly, a 1 line PR is counter productive and will take more time.

[zaggino]

Ok, I'll install 0.10.36 on my machine to see if there might be any hidden issues.