search

brad-cannell / codebookr

Create Codebooks From Data Frames
https://brad-cannell.github.io/codebookr/
Other
26 stars 7 forks source link

Add to CRAN #18

Closed mbcann01 closed 2 years ago

mbcann01 commented 2 years ago

There are improvements you want to make, but I think now is a good time to at version 1 to CRAN.

mbcann01 commented 2 years ago

First submission on 2022-07-09

I was getting an error from devtools::check_rhub("solaris-x86-patched"):

❯ checking package dependencies ... ERROR
  Package suggested but not available: ‘testthat’

  The suggested packages are required for a complete check.
  Checking can be attempted without them by setting the environment
  variable _R_CHECK_FORCE_SUGGESTS_ to a false value.

  See section ‘The DESCRIPTION file’ in the ‘Writing R Extensions’
  manual.

This seems to have something to do with the machine this is running on not being able to load testthat. I'm not sure what I can do about it.

I was also getting an note from devtools::check_rhub("solaris-x86-patched"):

❯ checking CRAN incoming feasibility ... NOTE
  Maintainer: ‘Brad Cannell <brad.cannell@gmail.com>’

  New submission

  Possibly mis-spelled words in DESCRIPTION:
    Codebooks (2:15)
    codebook (7:18)
    codebooks (8:10)

I think this can safely be ignored. We'll see.

mbcann01 commented 2 years ago

Response on 2022-07-14

Thanks,

Please always write package names, software names and API (application programming interface) names in single quotes in title and description. e.g: --> 'codebook' Please note that package names are case sensitive.

Please do not start the description with "This package", package name, title or similar.

\dontrun{} should only be used if the example really cannot be executed (e.g. because of missing additional software, missing API keys, ...) by the user. That's why wrapping examples in \dontrun{} adds the comment ("# Not run:") as a warning for the user. Does not seem necessary. Please unwrap the examples if they are executable in < 5 sec, or replace \dontrun{} with \donttest{}.

Please fix and resubmit.

Best, Victoria Wimmer

mbcann01 commented 2 years ago

Response on 2022-07-15

Thanks, we see: Size of tarball: 6519658 bytes Not more than 5 MB for a CRAN package, please.

mbcann01 commented 2 years ago

Resubmit on 2022-07-16