search

brad-lin / FreePSXBoot

Exploit to allow loading arbitrary code on the PSX using only a memory card (no game needed)
MIT License
574 stars 44 forks source link

std::memcpy -> memcpy #101

Open socram8888 opened 1 year ago

socram8888 commented 1 year ago

Current code is causing compilation errors in Debian bookworm. Replacing std::memcpy with just memcpy (as the rest of the memcpy calls are) fixed the issue.

builder.cc: In function ‘void createImage(ImageSettings, const uint8_t*, uint32_t)’:
builder.cc:693:14: error: ‘memcpy’ is not a member of ‘std’; did you mean ‘wmemcpy’?
  693 |         std::memcpy(out.data() + out.size() / 2, out.data(), out.size() / 2);
      |              ^~~~~~
      |              wmemcpy
alex-free commented 1 year ago

Duplicate of https://github.com/brad-lin/FreePSXBoot/pull/97

alex-free commented 1 year ago

Actually I don't know what's better. I initially did the same thing for my pull request but then realized I could just add #include cstring to fix it and settled on that.

socram8888 commented 1 year ago

Not sure. There's only one std::memcpy and plenty of regular memcpy in that file, so I guessed this one was a mistake.