brad0351 / hero-banner

Use CSS position to make a hero banner with text displayed in front of an image.
0 stars 0 forks source link

Hero Banner Text Background Colour Issue #1

Open brad0351 opened 6 years ago

brad0351 commented 6 years ago

Hello @thomasjbradley,

I am having great difficulty completing my hero-banner assignment. I attended the extra help class, but it was busy and the tutor was not able to allocate enough time to help me. My issue is that I cannot get the background colour of the text to have a break between the two lines. I also cannot figure out how to stop it from stretching the width of the page. I need it only to be as long as the text. I will work on other projects in the meantime. I feel like I need extra help overall in this class. Hope to hear back from you soon.

Cheers,

Jake Bradley

thomasjbradley commented 6 years ago

Have you committed and pushed recently? Not not seeing very much online right now.

brad0351 commented 6 years ago

Hey Thomas, sorry about the commit not being implemented again. I have just done that. Let me know what you think. Thanks again.

thomasjbradley commented 6 years ago

Background colour—

Have you tried setting the <h1> to be display: inline?


Content stretching—

That’s what the max-width is for, put it on the .banner-content and it will stop stretching the whole width.