search

bradandersonjr / GuitarEngine

Fusion 360 Guitar Generation Add-in
Apache License 2.0
26 stars 14 forks source link

Made a few changes.. #4

Open PuzzlingMatt opened 3 years ago

PuzzlingMatt commented 3 years ago

Made a few changes to split out logical blocks of code from the main python script and to have a bit of a refactor around the adding of the controls to the tabs. The main aim was to make it persist the control values so that if you want to tweak the settings you can - should now be able to hit create/undo then open it up again and the previous values will be there.

Since control values are stored in the document they should also persist going forward too so you can load up previous docs and still have all the values. Also, since they're stored as json it should be fairly easy to add setting import/export at some point (didnt want to change too much in one go and this was turning into a monster change anyhow).

clenchedteeth commented 3 years ago

I noticed this PR has sat for a while, is the plugin under active development? I am tempted to look into fixing my recent bug report myself, but not if the fix will never be merged.

PuzzlingMatt commented 3 years ago

Not sure re development I'm afraid. That said, the changes made in this pr actually remove the units dropdown and lets the plugin rely on the document settings.

Since the design params are stored in the document as the f360 internal unit (cm) it should display the correct units each time you open the plugin but, it looks like theres a bit of an issue there! I'll got take a look at that this weekend, I could have sworn it was working. I'll make the initial window a bit wider while I'm at it since its a 10 second thing to change

clenchedteeth commented 3 years ago

Awesome, thanks. I guess I will follow your fork unless @BradAndersonJr continues development.