search

bradandersonjr / GuitarEngine

Fusion 360 Guitar Generation Add-in
Apache License 2.0
24 stars 14 forks source link

Several issues with default parameters #7

Open martinverner opened 1 year ago

martinverner commented 1 year ago

Hi Brad,

I get several issues when creating a guitar using default values.

`Failed: Traceback (most recent call last): File "C:/Users/.../Fusion 360 plugins/GuitarEngine-master-391276a/Guitar Engine [Beta].py", line 1583, in buildFretboard extentToEntity = adsk.fusion.ToEntityExtentDefinition.create(extrudeFeature.faces.item(0), True) File "C:\Users/...

GuitarPluginIssues GuitarPluginIssues

/AppData/Local/Autodesk/webdeploy/production/dbacedcc6dabacdc41406088a765962c5f1923ad/Api/Python/packages\adsk\fusion.py", line 9935, in item return _fusion.BRepFaces_item(self, index) RuntimeError: 2 : InternalValidationError : faces.size() > index`

And

Failed: Traceback (most recent call last): File "C:/Users/.../Fusion 360 plugins/GuitarEngine-master-391276a/Guitar Engine [Beta].py", line 1932, in buildPickups constraints.addMidPoint(bridgeLines.item(5).startSketchPoint, cavitybridgeLines.item(9)) File "C:\Users/.../AppData/Local/Autodesk/webdeploy/production/dbacedcc6dabacdc41406088a765962c5f1923ad/Api/Python/packages\adsk\fusion.py", line 41855, in item return _fusion.SketchLines_item(self, index) RuntimeError: 3 : Bad index parameter

The end result looks like this:

GuitarPluginIssues

Otherwise, really cool plugin and good videos on Youtube. Thank you very much!

Fusion 36 version 2.0.16490 x86_64

martinverner commented 1 year ago

If I uncheck "Create Fret Cuts" and select Humbucker for bridge pickup, it works. Of course, I do not get Fret Cuts.

martinverner commented 1 year ago

Changing line 1583 to this seems to fix the Fret cutting issue

extentToEntity = adsk.fusion.ToEntityExtentDefinition.create(offSurf.faces.item(0), True)