bradchoate / text-textile

Text::Textile -- Perl module for handling Textile format
20 stars 11 forks source link

Add disable_inline_formatting option #23

Closed michael-on-github closed 6 years ago

michael-on-github commented 7 years ago

Add an option disable_inline_formatting so that things like <p>*sigh*</p> do not get converted to <p><strong>sigh</strong></p>.

Usage:

my $textile = Text::Textile->new( disable_inline_formatting => 1 );
finn commented 7 years ago

Hi, @bradchoate -- this is an additional change we have made to Text::Textile to control its behavior in a more fine grained way.

A followup to the previous changes we submitted here and here:

finn commented 7 years ago

@bradchoate re-reviewing the closed PRs on this repo I see you have an alternative take on this behavior here:

https://github.com/bradchoate/text-textile/pull/7#issuecomment-48194267

Are you open to the proposed flag in this PR being added? Or should we pursue the sub-classing approach you outline in that comment instead?

finn commented 7 years ago

We subclassed as discussed in #7. Feel free to close.

yacomink commented 7 years ago

Nice work, @finn