Use of uninitialized value $1 in string eq at /usr/share/perl5/Text/Textile.pm line 89

bradchoate / text-textile

Text::Textile -- Perl module for handling Textile format

20 stars 11 forks source link

Use of uninitialized value $1 in string eq at /usr/share/perl5/Text/Textile.pm line 89 #4

Open nickleverton opened 13 years ago

nickleverton commented 13 years ago

Similar problem to that noted by domm resulting in much noise printed to stderr.

--- /usr/share/perl5/Text/Textile.pm.orig 2009-08-08 19:20:45.000000000 +0100 +++ /usr/share/perl5/Text/Textile.pm 2011-07-29 14:21:57.000000000 +0100 @@ -86,7 +86,7 @@ my $flavor = shift; $self->{flavor} = $flavor; if ($flavor =~ m/^xhtml(\d)?(\D|$)/) {

if ($1 eq '2') {
if (defined $1 && $1 eq '2') { $self->{_line_open} = ''; $self->{_line_close} = ''; $self->{_blockcode_open} = '';

nickleverton commented 12 years ago

360 days later the same issue bites me again on another new server :-( Pretty please could the fix be released ?

bradchoate commented 10 years ago

I'm not sure what the issue here is. Is the flavor method being called somewhere with an undefined value? A small bit of code that reproduces the warning would be helpful.

nickleverton commented 9 years ago

Hi Brad, Thanks for the reply, sorry didn't get back to you sooner as life intervened. I have a CGI which uses the very excellent Text::Textile and sets flavour() to 'xhtml', which is a valid choice according to the docs. This causes the warning when a textile template is processed and flavour is matchedd by the above code, as $2 is null.