bradchoate / text-textile

Text::Textile -- Perl module for handling Textile format
20 stars 11 forks source link

improve whitespace handling in image processing #9

Closed serap closed 10 years ago

serap commented 10 years ago

Hi Brad,

thank you for your work on Text::Textile.

We love your module and impressed by your regex skills. However we feel that we found a bug in the image parsing part.

Please check an hopefully apply the patch if you agree with my version.

NB: I have not checked other tags for the same issue ...

Best regards and Happy Easter! Serap

prevent images parser from interpreting ! noimage ! as image tag

(?:(?<=[^!])\s+)?

optionally match one or more spaces that must not be preceeded by an exclamation mark. if any of the optional alignment or css options are used a space is acceptable otherwise not.

pepl commented 10 years ago

Hey Brad,

This pull request would be really helpful if applied.

Are you still interested in the module? Do you want to orphan the CPAN module?

Regards, Michael

serap commented 10 years ago

Hey Brad,

thank you for merging!

Regards, Serap