Laravel 6 Support

[rikiless]

cornford/googlmapper v2.34.0 requires illuminate/view 5. cornford/googlmapper v2.33.0 requires illuminate/support 5.

[felipesmendes]

Up

[felipesmendes]

@rikiless did you solve the problem? its seems the package is not maintained.

[rikiless]

I just edited composer.json to require illuminate/view 6. & illuminate/support 6. in my fork. But I did not tested the functionality yet. I need to resolve billing to Google Cloud Platform (Google Maps API) first.

[felipesmendes]

@rikiless Could you send me step by step how to do this?

I just edited composer.json to require illuminate/view 6. & illuminate/support 6. in my fork

[dircm]

I can cofirm by forking and changing the composer.json "require" to

"require": {
        "illuminate/view": "6.*",
        "illuminate/support": "6.*"
    },

Is working in my Laravel v6.0.3 projects.

[UXandre]

@dircm can you please elaborate on how I can install the package I forked and edited? Tried to fork the repo, edit the versions, and uploaded to Packgist. But it said the package is owned and maintained by the author. Would appreciate a quick pointer! Thank you!

[bradcornford]

I've been away with a family bereavement so haven't had time to merge this until now.

I've merged the PR for this, and versioned it as current version v2.35.0. I haven't had time to try version Laravel 6 yet however.

[dircm]

@dircm can you please elaborate on how I can install the package I forked and edited? Tried to fork the repo, edit the versions, and uploaded to Packgist. But it said the package is owned and maintained by the author. Would appreciate a quick pointer! Thank you!

Hi @UXandre have a look at https://getcomposer.org/doc/05-repositories.md#vcs

The basics of what I did were:

1. Fork this repo.

2. Make the changes (bug fixes etc) to the code on your own fork.

3. Add the require to your project composer.json require (here is mine) "dircm/googlmapper": "master",

4. Add the VCS repository to your project composer.json (here is mine). Note the VCS repository will always be searched first over other repos.

   "repositories": [
       {
           "type": "vcs",
           "url": "https://github.com/dircm/Googlmapper.git"
       }
   ]

5. If your forked repo is private (like mine is) you will need to generate a personal token to allow your project to download the package. See https://help.github.com/en/articles/creating-a-personal-access-token-for-the-command-line

6. run composer update

[UXandre]

@dircm can you please elaborate on how I can install the package I forked and edited? Tried to fork the repo, edit the versions, and uploaded to Packgist. But it said the package is owned and maintained by the author. Would appreciate a quick pointer! Thank you!

Hi @UXandre have a look at https://getcomposer.org/doc/05-repositories.md#vcs

The basics of what I did were:

1. Fork this repo.
2. Make the changes (bug fixes etc) to the code on your own fork.
3. Add the require to your project composer.json require (here is mine) "dircm/googlmapper": "master",
4. Add the VCS repository to your project composer.json (here is mine). Note the VCS repository will always be searched first over other repos.

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/dircm/Googlmapper.git"
        }
    ]

1. If your forked repo is private (like mine is) you will need to generate a personal token to allow your project to download the package. See https://help.github.com/en/articles/creating-a-personal-access-token-for-the-command-line
2. run composer update

@dircm thanks so much for this, Tom. I am away pitching around our startup but will give a go on Friday. Really appreciate the detailed explanation!

[dircm]

@dircm can you please elaborate on how I can install the package I forked and edited? Tried to fork the repo, edit the versions, and uploaded to Packgist. But it said the package is owned and maintained by the author. Would appreciate a quick pointer! Thank you!

Hi @UXandre have a look at https://getcomposer.org/doc/05-repositories.md#vcs The basics of what I did were:

1. Fork this repo.
2. Make the changes (bug fixes etc) to the code on your own fork.
3. Add the require to your project composer.json require (here is mine) "dircm/googlmapper": "master",
4. Add the VCS repository to your project composer.json (here is mine). Note the VCS repository will always be searched first over other repos.

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/dircm/Googlmapper.git"
        }
    ]

1. If your forked repo is private (like mine is) you will need to generate a personal token to allow your project to download the package. See https://help.github.com/en/articles/creating-a-personal-access-token-for-the-command-line
2. run composer update

@dircm thanks so much for this, Tom. I am away pitching around our startup but will give a go on Friday. Really appreciate the detailed explanation!

@UXandre I dont think you are forking this repo correctly. Have a look at https://blog.scottlowe.org/2015/01/27/using-fork-branch-git-workflow/

[dircm]

Hi @rikiless this issue should be closed now. All working with new release.

[rikiless]

@dircm @felipesmendes I did it the same way 🙂 Simple, fast and temporary. Fork and update package by yourself. Then in composer.json required package changed to dev-master:

"cornford/googlmapper": "dev-master",

and added mine VCS repo:

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/rikiless/Googlmapper"
        }
    ],

But you don't need to do this anymore. Thanks for updating library.