braden-w / whispering

https://whispering.bradenwong.com/
MIT License
244 stars 26 forks source link

4.7.1 No recording ability #219

Closed cgbur closed 1 month ago

cgbur commented 1 month ago

Just updated to 4.7.1 on mac intel. Unable to find any recording devices and lost my api keys so had to re add them. Still not able to find any devices. Restarted it several times and checked permissions.

I know its asking a lot but perhaps some level of automated testing could be added to CI, it is difficult to blindly trust updating currently without fear of the app being broken afterwards.

I downgraded to 4.6 and it works as expected

braden-w commented 1 month ago

Oh man I'm so sorry about this, I cancelled 4.7.0 because it was broken, then made a few changes, double checked the app on my own machine, and it worked and I guess now it's broken once more :/ sorry about that and will revert!

The problem was ever since I included signing in the application on MacOS in #206, the audio permissions have been broken. Am trying to find a fix as we speak!

I unfortunately am unsure what the best way for testing is. I personally download the .dmg before releases, but am unsure how to run tests given that most of the build step is done in a GitHub action provided by Tauri.

There is no excuse for my lack of caution, however. Expect fewer breaking updates in the future!

braden-w commented 1 month ago

@cgbur Could you confirm if the .dmgs in this pre-release work?

https://github.com/braden-w/whispering/releases/tag/main

I tried replicating the issue but for some reason, it actually works on my machine now.

Really strange, since I had the same issue before (no recording ability). Then I made a modification to a .plist file, then undid it, but now the app always works for me despite having the older code 😅 unsure what changed, so just wanted confirm that the issue is on my machine .

cgbur commented 1 month ago

Totally understand testing UI based stuff on this many platforms is a nightmare.


Error enumerating recording devices
Please make sure you have given permission to access your audio devices

But i have gone in and removed and added permissions. Is there a way to launch the app with logging? When I run it through open /Applications/Whispering it just opens returns.

braden-w commented 1 month ago

Awesome, thanks so much! I'm going to continue iterating and testing and might send a few more .dmgs in prerelease your way since I can't get this bug on my computer anymore for some reason 😵‍💫

Did you try running open /Applications/Whispering.app? And by logging, do you mean logging with Console?

braden-w commented 1 month ago

The main issue is that this bug only exists in production builds from GitHub actions; it works in dev and prod builds on my machine. It has been a reproducibility nightmare hehe 😅

cgbur commented 1 month ago

Yeah trying

open -a /Applications/Whispering.app -o ~/whiper.log

and

tail -F ~/whisper.log

but the open command returns immediately no matter how i run it and does not hook in and give me any stdout or stderr logging streams.

braden-w commented 1 month ago

Ok, just like a few hours ago, I assume the issue is something to do with a .plist file being respected now that code signing is a thing. I'm reopening #218 and will be merging and setting a pre-release—will send you it once it's ready!

braden-w commented 1 month ago

@cgbur Could you take a look at this release? Took a while, but I tried removing sandboxing and hopefully it worked out!

https://github.com/braden-w/whispering/releases/tag/feature%2Fwhi-61-hotfix-infoplist-permissions-after-code-signing

worldoptimizer commented 1 month ago

CleanShot 2024-07-26 at 13 30 23@2x

Using 4.7.1 I also get this. Hope I am not the cause for requesting the signing to begin with.

cgbur commented 1 month ago

Got the same double error, then this has remained:

Screenshot 2024-07-26 at 9 11 20 AM

braden-w commented 1 month ago

Just pushed a fix in 4.7.2 that removes code signing and is a temporary fix. Will continue to experiment with plist for code signing!

braden-w commented 1 month ago

Going to close this and run experiments off the main branch to restore notarization in #223