search

braden-w / whispering

https://whispering.bradenwong.com/
MIT License
277 stars 31 forks source link

Prevent accidental recording of 2+ hour recordings #69

Closed braden-w closed 3 months ago

braden-w commented 10 months ago

Some users have accidentally recorded very long recordings with the extension. Better visibility of recording status, warnings, etc. would be appreciated.

swimJim commented 9 months ago

Yes please. I dislike ending up with a five hour-long recording because the hotkey does not seem to trigger. It would be great if you could set a maximum length in minutes for individual recordings so that, for instance, Whispering would automatically stop any single recording that exceeded 20 minutes or whatever time you set for individual recordings.

HamzaETTH commented 9 months ago

To try to prevent this, I've quickly made a fork where the program minimizes to the system tray instead of closing, and the tray icon changes to include a red circle when it's recording. You can check it out.

swimJim commented 8 months ago

I would love to try your fork, but I'm a noob who can only run Windows executables. Do you have a happy compiled version of your fork with a notification feature?

MuhsinunC commented 8 months ago

To try to prevent this, I've quickly made a fork where the program minimizes to the system tray instead of closing, and the tray icon changes to include a red circle when it's recording. You can check it out.

I really like this idea. I think that this would be a great thing to implement into the official project. I know Discord, for example, has a little icon that lights up when it's recording your mic, and that makes it really easy to tell if your mic is muted or not.

HamzaETTH commented 8 months ago

I would love to try your fork, but I'm a noob who can only run Windows executables. Do you have a happy compiled version of your fork with a notification feature?

Here.

swimJim commented 8 months ago

Thank you, I just had a three hour long recording today, that I did not intend. You are my hero for saving me my pennies.

DavidGP commented 6 months ago

This fork is amazing and such a big improvement! It also seems to be more stable in that it no longer takes the focus away from the current window, which seemed to happen with the original version. Braden, when continuing the development of Whispering, please retain this feature and build upon this fork. Thanks all!

Maybe as one of the next steps, we can include the ability to start whispering minimized to the Tray?

doxgt commented 5 months ago

This fork is amazing and such a big improvement! It also seems to be more stable in that it no longer takes the focus away from the current window, which seemed to happen with the original version. Braden, when continuing the development of Whispering, please retain this feature and build upon this fork. Thanks all!

Maybe as one of the next steps, we can include the ability to start whispering minimized to the Tray?

I have only used this fork as well. In fact David introduced this app and fork to us at a Speech Recognition forum (thanks David)!

Very intuitive and user-friendly.

swimJim commented 5 months ago

I would love to try your fork, but I'm a noob who can only run Windows executables. Do you have a happy compiled version of your fork with a notification feature?

Here.

Is there any way you could modify the fork to work with the recent API changes?

doxgt commented 4 months ago

Supposedly Whisper on OpenAI rejects any raw audio file > 25 MB. WAV format that Whispering records at generates approximately 10 MB/min, even with "silence" (I didn't verify this personally). Thus any WAV recording from Whispering over 3 min in length is unlikely to result in consumption of tokens or success of transcription, in theory anyway.

braden-w commented 3 months ago

Hey everyone, sorry for jumping on this thread so late—I finally have returned to development a few months later!

I added a cancel button in the 4.0.0 release #108 and it should hopefully be working in the latest version (as of writing, v4.2.1).

Could you guys let me know if the new implementation is missing anything, and I'll get to work? In the meantime, I'll close this issue as addressed. Reopen if issue persists. Thank you all once again!