bradfeehan / SublimePHPCoverage

A plugin for Sublime Text 2 and 3, which visualises PHP code coverage data in the editor.
MIT License
57 stars 10 forks source link

Python error in matcher.py #17

Closed hkdobrev closed 10 years ago

hkdobrev commented 11 years ago

I have installed via git the latest version: https://github.com/bradfeehan/SublimePHPCoverage/tree/479cbbd7df61f6d347772d9a5558ab4753e2857b

The configuration looks like to be correct, but here is what I see in the Sublime Text 3 console:

Traceback (most recent call last):
  File "/Applications/Sublime Text.app/Contents/MacOS/sublime_plugin.py", line 549, in run_
    return self.run(edit)
  File "~/Library/Application Support/Sublime Text 3/Packages/SublimePHPCoverage/SublimePHPCoverage.py", line 105, in run
    if not self.should_include(filename):
  File "~/Library/Application Support/Sublime Text 3/Packages/SublimePHPCoverage/php_coverage/command.py", line 55, in should_include
    return self.get_matcher().should_include(filename)
  File "~/Library/Application Support/Sublime Text 3/Packages/SublimePHPCoverage/php_coverage/matcher.py", line 18, in should_include
    return self.included(filename) and not self.excluded(filename)
  File "~/Library/Application Support/Sublime Text 3/Packages/SublimePHPCoverage/php_coverage/matcher.py", line 24, in included
    return self.match(config.include, filename)
  File "~/Library/Application Support/Sublime Text 3/Packages/SublimePHPCoverage/php_coverage/matcher.py", line 37, in match
    if re.search(pattern, string):
  File "X/re.py", line 161, in search
TypeError: expected string or buffer
hkdobrev commented 11 years ago

I have managed to fix it. This is my first Python code so if I have missed something please explain.

sporchia commented 10 years ago

You should do this pull, I tested on Mac OSX, with Sublime Text 2. And it solved my problems.

bradfeehan commented 10 years ago

Sorry that this took so long to merge. :disappointed: