bradgearon / hdr-switch

turns hdr on while running for windows 10
MIT License
188 stars 16 forks source link

HDR Mode should be remembered when PC is restarted while the switch is on #17

Open teijiIshida opened 3 years ago

teijiIshida commented 3 years ago

Issue: When the "HDR Mode" switch is ON in the tray icon and I restart the PC, it will not remember the status in the tray after the restart (ie. the tray icon shows HDR Mode is off, even though HDR is still on in Windows Settings).

Proposed Solution 1: Automatically turn off HDR Mode and HDR in Windows Settings when a PC restart/shutdown is detected.

Proposed Solution 2: Remembers the previous "HDR Mode" status after a PC restart/shutdown (save the status in a boolean whenever a user turn it on/off?).

Barnacules commented 3 years ago

I think a better solution would be to call DisplayConfigGetDeviceInfo() or one of the DX api's (I'm really rusty) to get the current state of the screens then reflect that actual state Windows 10 is reporting to the current menu selection. This way you don't have to store anything else in the registry or rely on everything staying in sync or being applied again unnecessarily.

I'm looking at potentially doing some work on this project since being able to enable and disable HDR across multiple screens is something I really want to do with my Streamdeck and game shortcuts and this project is 95% of the way there honestly and it works fantastic. Time to see if I still have any coding chops after 15 years working at Microsoft as a Senior Software Developer then leaving for 8 years and doing very little coding after that.

Wish me luck 😉