search

bradgearon / hdr-switch

turns hdr on while running for windows 10
MIT License
189 stars 16 forks source link

Closing HDR Switch after an HDR game was closed is not turning HDR off #4

Open Trilyan opened 4 years ago

Trilyan commented 4 years ago

Seems HDR Switch does not have control of HDR setting after you launch an HDR app.

To test this I tried the following:

1- Manually set HDR to OFF 2- Run HDR Switch --> HDR turns ON 3- Run HDR game 4- Close HDR game 5- Close HDR Switch --> HDR is not turning OFF

I'm going to try and understand your code, but to me it seems that a new "hook" must be done to regain control of the setting

bradgearon commented 4 years ago

the nvapi hook is meant to be used by game developers if what game is it that you are running? it might have something funky going on that hard enables it -- the nvapi version only works while the app is running but there is a registry key that can be used to enable it afaik

Trilyan commented 4 years ago

This is happening mostly with Red Dead Redemption 2 and Call of Duty Modern Warfare. Seems like the game "takes over" and then HDR Switch is unable to change the setting to OFF when it gets closed. I need to test the behavior on the tray version and see if it still happens