search

bradhannah / Ultima5Redux

A mostly true to the original Ultima 5 remake in C# using the original U5 data files.
https://u5redux.wordpress.com/
MIT License
65 stars 7 forks source link

Consider moving MapUnits under Map.cs #443

Closed bradhannah closed 1 year ago

bradhannah commented 1 year ago

By moving it under the Map.cs it will save a lot of upward calls to VirtualMap, and simplify the virtual map as well.

This will require rework of the MapUnitCollection as well - in fact, most of the functionality may actually move down it

bradhannah commented 1 year ago

This continues to be a major refactor - but is much more intelligent than previous.

Virtual map has been stripped of a lot of functionality, as it is place lower down in the maps themselves. This results in fewer checks in many of the routines such as combat map routines that only exist in the combat maps now.

bradhannah commented 1 year ago

This was massive but is complete.

It had the desired result and is much cleaner and easier to work with.