Adding saves to unit tests

[mandlar]

Hello @bradhannah!

I was able to get unit tests working, but had to make a few modifications.

• I added Nuget packages to run NUnit tests natively in Visual Studio's Test Explorer. It looks like you are using Resharper to run your tests (but I do not have Resharper installed). This shouldn't affect Resharper running the tests, but let me know if it does.
• I imported all of the save files you are using in your tests. However, we are missing "blackt" and "brandnew" saves.
• I stubbed a data directory for the game data files. I included a .gitignore to ignore committing these files and added a readme stating the purpose of the directory.
• All of the Data, LegacySaves and NewSaves directories will always be copied to the output directory for running the unit tests
• I refactored the unit tests to use these new directories stored in the unit test project instead of the hard coded paths.

The directory paths could probably be simplified more but wasn't quite sure about non-Windows environments since you have a check for OSX. And as well I'm not sure where TestContext.Parameters() gets data from.

For example, this directory variable:

private string SaveRootDirectory =>
            TestContext.Parameters.Get("SaveRootDirectory",
                RuntimeInformation.IsOSPlatform(OSPlatform.OSX)
                    ? @"/Users/bradhannah/GitHub/Ultima5ReduxTestDependancies/Saves"
                    //@"/Users/bradhannah/games/u5tests"
                    : GetDirectory(DirectoryType.LegacySaves));

Could be reduced to something like:

private string SaveRootDirectory =>
            GetDirectory(DirectoryType.LegacySaves);

But I didn't want to break anything for you :)

All of the tests pass for me (except for the ones with the missing save files).

Thanks! Bryan

[bradhannah]

Hey @mandlar (Bryan)! Apologies for > 1 month delay. I reviewed the changes and like what you did. I even removed my own hardcoded path and used your function. Glad you got them to run. Never had someone actually try to run my unit tests lol!

The .gitignore was a nice touch for the "just in case" scenario too.

I am adding in the missing tests as well. The "new saves" have morphed many times and need constant updating as I change the alter the save schema.

Thanks again! - Brad

[mandlar]

No problem, glad you liked the changes! I just figured I'd start somewhere easy and getting unit tests to work seemed like a good candidate!