search

bradharding / doomretro

The classic, refined DOOM source port. For Windows PC.
https://www.doomretro.com
GNU General Public License v3.0
687 stars 86 forks source link

Controls not responding to short taps? #119

Closed VGkav closed 4 years ago

VGkav commented 9 years ago

When I shortly tap a movement button it usually doesn't get registered (player doesn't move) Using uncapped framerate with Vsync disabled.

I couldn't find a cvar to enable showing fps, but Fraps shows me 600-700 fps :-D

bradharding commented 9 years ago

I don't seem to be able to replicate this issue. The quickest tap of a movement key causes the player to move without fail. Does the problem still occur if you set vid_capfps to on? How about DOOM RETRO v1.6.7?

As for the cvar to show fps, it's com_showfps. (I think I made need to change it, since "com" (short for "common") is a bit redundant since there's no "client"/"server".)

VGkav commented 9 years ago

Shouldn't it be vid_showfps? Anyway I can't reproduce the problem on my laptop, I'll investigate on my main PC tomorrow.

VGkav commented 9 years ago

1) I can't replicate the problem in the latest stable from your site.

2) vid_capfps doesn't make a difference

3) All short taps get registered fine in the console!

VGkav commented 4 years ago

Single tapping the WASD keys result in no movement about 1/3 of the time, I had noticed it a long time ago, too. Can you replicate it? Just load MAP01 and pretend you want to move 1mm forwards and then 1mm to another direction etc. Just quickly tap the WASD keys every half a second in random directions.

It's fine in other ports.

bradharding commented 4 years ago

Thanks @AnotherLife. I'll look into this soon.

bradharding commented 4 years ago

I have been able to replicate this issue, and after a similar problem being mentioned here, I've determined the cause of the issue to be here:

https://github.com/bradharding/doomretro/blob/master/src/doomretro.c#L85

The LowLevelKeyboardProc() function blocks presses of the left and right Windows keys, and intercepts the Printscreen key so a png file is saved rather than anything being copied to the clipboard. I'll need to look into this rather than just take this out altogether as I want to retain this exact functionality.

bradharding commented 4 years ago

Hi @AnotherLife. And thanks again. Could you please confirm this no longer occurs for you in this build? https://www.dropbox.com/s/2zncczmg15n8awy/doomretro-3.5.2beta1-win64.zip?dl=1

VGkav commented 4 years ago

With this new beta build I cannot reproduce the problem, nice job!