bradharding / doomretro

The classic, refined DOOM source port. For Windows PC.
https://www.doomretro.com
GNU General Public License v3.0
635 stars 79 forks source link

MP3 soundtrack does not loop #558

Open ozy24 opened 4 years ago

ozy24 commented 4 years ago

Hi Brad,

I posted this on disqus already but thought i'd post it here to make it more official. :)

I'm using a custom WAD that replaces the midi soundtrack with MP3 files from PSX doom. The music plays fine, but only once. At the end of the track it goes silent and the music does not repeat.

I have uploaded the WAD file here, if this helps.

https://easyupload.io/zd944n

This happens on v3.2.1

Many thanks,

Chris

bradharding commented 4 years ago

Thanks for the report. Well, I loaded up DOOM2.WAD with the PWAD you provide, and after the 8 mins or so, yes, the D_RUNNIN MP3 lump doesn't repeat. However, I then loaded up DOOM.WAD with SIGIL.WAD and SIGIL_SHREDS.WAD and the D_E5M1 MP3 lump does loop. I'm not familiar with the format of MP3 files, but maybe it's an issue with the files themselves?

ozy24 commented 4 years ago

Hi Brad,

I re-encoded D_RUNNIN.mp3 with a modern LAME encoder and imported it back into the WAD and it repeated fine.

So the issue is definitely the way the MP3 files were encoded to begin with (not done by me so no idea which tool was used).

Doom Retro is the only port i've used that has this issue but it's easy enough to re-encode all the files with LAME.

Thanks for looking into it. :)