bradharding / doomretro

The classic, refined DOOM source port. For Windows PC.
https://www.doomretro.com
GNU General Public License v3.0
698 stars 88 forks source link

thoughts... #797

Closed devnexen closed 1 year ago

devnexen commented 1 year ago

These are the only remaining overflow so far

p_mobj.c:1248:80: runtime error: signed integer overflow: 536870912 * 6 cannot be represented in type 'int'
...
p_mobj.c:1041:80: runtime error: signed integer overflow: 536870912 * 6 cannot be represented in type 'int'

Now, even chocolate doom is doing the same so it seems an historical occurrence, so "fixing" it might change the behaviour of the game. But I do not know enough to say if it s on purpose :-)

bradharding commented 1 year ago

I'm not sure to be honest. Maybe best to leave them alone?

devnexen commented 1 year ago

Yeah sounds reasonable indeed.