bradharding / doomretro

The classic, refined DOOM source port. For Windows PC.
https://www.doomretro.com
GNU General Public License v3.0
698 stars 88 forks source link

Crash when looking at Spectres on liquids. #808

Closed BeemerJ closed 1 year ago

BeemerJ commented 1 year ago

Bit of a weird one...

I'm currently playing through with D2TWID.wad and whenever I look directly at this Spectre in map 2 (and others) my game crashes.

Compound, The

I've tried disabling liquid swirl / bob, shadows, as well as swapping over from "direct3d" to "opengl" to no avail. Also tried with a fresh download of DOOM Retro just running the wad and it still crashes ☹

Tried updating my AMD drivers but nope.

condump.txt doomretro.cfg

Love everything else about this source port though, just this issue unfortunately.

bradharding commented 1 year ago

Thanks for the report. Just tested this myself, using both D2TWID.wad and BlackOps.wad, and wasn't able to replicate the crash, however, I'm guessing the spectre is attempting to be drawn off-screen. I'll look into it further.

BeemerJ commented 1 year ago

Can I send you a video if it makes diagnostics easier?

bradharding commented 1 year ago

A video isn't necessary, I don't think. But could you please provide the error report from the Windows Event Viewer?

bradharding commented 1 year ago

Also, on a hunch that this could be a simple fix, can you try the following build? test.zip

BeemerJ commented 1 year ago

crash.txt

It still crashes with the test build 😔

BeemerJ commented 1 year ago

OK I don't even think it's the Spectres causing the crash, because even if i get the Spectre out, looking down funny at liquids from a ledge crashes.

Standing directly in it weirdly enough doesn't crash at all, it's only when I look down into it...sometimes

bradharding commented 1 year ago

Ah, I see what's happening now. It's fixed in the next release, but a crash will occur if a blood splat touches the top of the screen when you look down, and I see you're using mouselook. Can you please test with mouselook off or r_bloodsplats_max 0?

BeemerJ commented 1 year ago

Yoooo, yeah it was the bloodsplats 👍 Awesome man, how much is an Australian coffee? 😂

bradharding commented 1 year ago

Awesome man, how much is an Australian coffee?

Not necessary! :) (Unless that was you who donated earlier today, in which case: Thank you!)

Here's a beta with the fix (and tons of other stuff) for your troubles!