search

bradleyayers / django-celery-transactions

Django transaction support for Celery tasks.
Other
195 stars 56 forks source link

Django 1.6 #11

Open grillermo opened 10 years ago

grillermo commented 10 years ago

I have not noticed anything breaking, but i'm not sure if with the new transaction management in django 1.6 do i have to make changes to this library.

alurin commented 10 years ago

New transaction decorator atomic (used in django admin) is not covered, e.g saves in admin is not sended existing monkey pathing signals.

And after reading https://code.djangoproject.com/ticket/21004: transaction.is_managed() in Django 1.6 always returns False.

I'm think because of this django-celery-transactions is fully broken. All post transaction tasks call method apply_async from super class.

Tested on Python 2.7(Ubuntu 10.10) with this list of packages:

django-celery==3.0.23
django-celery-transactions==0.1.3
git+git://github.com/toastdriven/django-haystack.git@v2.1.0
git+git://github.com/notanumber/xapian-haystack.git
django-haystack-panel==0.1.3
celery-haystack==0.7.2
nicpottier commented 10 years ago

Not sure I would necessarily recommend it, but I just updated my fork to work with 1.6 (and 1.6 only). Sorry, can't be bothered hacking around everything to make it backwards compatible seeing as everything in 1.6 dealing with transactions is brand new.

But it seems to work, so hey, maybe it will be useful.

https://github.com/nyaruka/django-celery-transactions