Add test and fix bug - Githubissues

bradleyayers / django-celery-transactions

Django transaction support for Celery tasks.

Other

195 stars 56 forks source link

Add test and fix bug #5

Closed nicolas-DH closed 11 years ago

nicolas-DH commented 11 years ago

Add real support for prior versions of Django1.3
Fix a bug regarding transaction.is_dirty flag:
- Tasks were fired even if transaction is aborted, because transaction wasn't dirty
Introduce a test suite, that you can run with the command python setup.py test This test suite prove the fix of the bug, and make sure my changes didn't break anything else

Feel free to comment, If there is something you don't like, I prefer hear your opinion and discuss, than being forced to fork this library !

bradleyayers commented 11 years ago

Thanks for this, I'm actually in the last stages of adding a test suite and fixing a bunch of stuff too. I'll go through your changes and try to combine them with what I've done.

nicolas-DH commented 11 years ago

Hi, What is the status for this PR ? If you want I can integrate my work inside your branch to help you.

Cheers, Nicolas

bradleyayers commented 11 years ago

@nicolas-DH I've been too busy over the last week to finish this, it's still high on my todo list, so I'll get to it soon. Thanks for the offer for help, I'll send you a message if I need help.

nicolas-DH commented 11 years ago

Any News ?