bradleyfalzon / gopherci

GopherCI was a project to help you maintain high-quality Go projects, by checking each GitHub Pull Request, for backward incompatible changes, and a suite of other third party static analysis tools.
https://gopherci.io
BSD 2-Clause "Simplified" License
102 stars 13 forks source link

PR comments should use Pull Request Reviews #112

Closed bradleyfalzon closed 7 years ago

bradleyfalzon commented 7 years ago

Currently GopherCI uses traditional inline comments to report issues. This creates a comment for each issue which in turn creates one email per issue and is very noisy.

GitHub have supported Pull Request Reviews for OAuth apps for some time, but appear to now support this API for GitHub Apps as well. Documentation doesn't suggest GitHub Apps support is available https://developer.github.com/v3/pulls/reviews/#create-a-pull-request-review but user comments appear to suggest it is https://platform.github.community/t/api-endpoint-for-pr-reviews/409/14.

We should use this mechanism to post comments, and allow the user of GopherCI to chose whether comments are simply comments, approve a PR or request changes. As per https://help.github.com/articles/about-pull-request-reviews/.

As we'll continue to support Status API, it may make sense to just leave reviews as comments.

Relates to #75.