Open bradleyfalzon opened 7 years ago
Another case may be if an exported function is removed.
[bradleyf@srv4 github_flavored_markdown (master)]$ apicompat
HEAD~1:main.go:76: breaking change declaration removed
func Header(heading atom.Atom, title string) *html.Node
[bradleyf@srv4 github_flavored_markdown (master)]$ apicompat | revgrep -d
DEBUG: diff --git a/main.go b/main.go
DEBUG: index 6354251..af3bd02 100644
DEBUG: --- a/main.go
DEBUG: +++ b/main.go
DEBUG: @@ -67,17 +67,6 @@ func Heading(heading atom.Atom, title string) *html.Node {
DEBUG: return h
DEBUG: }
DEBUG:
DEBUG: -// Header returns a heading HTML node with title text.
DEBUG: -// The heading comes with an anchor based on the title.
DEBUG: -//
DEBUG: -// heading can be one of atom.H1, atom.H2, atom.H3, atom.H4, atom.H5, atom.H6.
DEBUG: -//
DEBUG: -// Deprecated: Use Heading instead. This function was renamed to that, and will be deleted soon.
DEBUG: -func Header(heading atom.Atom, title string) *html.Node {
DEBUG: - // TODO: Remove this deprecated func after 2017-02-24.
DEBUG: - return Heading(heading, title)
DEBUG: -}
DEBUG: -
DEBUG: // extensions for GitHub Flavored Markdown-like parsing.
DEBUG: const extensions = blackfriday.EXTENSION_NO_INTRA_EMPHASIS |
DEBUG: blackfriday.EXTENSION_TABLES |
DEBUG: lines changed: map[main.go:[]]
DEBUG: path: "HEAD~1:main.go", lineNo: 76, colNo: 0, msg: "breaking change declaration removed"
DEBUG: unchanged: HEAD~1:main.go:76: breaking change declaration removed
DEBUG: cannot parse file+line number: func Header(heading atom.Atom, title string) *html.Node
I might be wrong, but I think this should not have been ignored