`git diff` error silenced

amenasria commented 1 year ago

Hey there 👋,

Stumbled upon some issues while working with golangci-lint.

Basically the fact that only the exit code is printed in the git diff calls in the GitPatch function but not the git diff stderr makes it really hard for people to debug. I have 2 use cases from this golangci-lint issue when using the new-from-rev feature:

In one case the new-from-rev commit was not in the commit tree because the Github Actions runner only had a shallow clone of the repository. From the error people just understood that the diff was not working. Having the error message would have made people understand it directly.
In another case (mine) the git diff didn't work because of a diff algorithm that couldn't be found in the runner. This wasn't understandable as well because no error, only the exit code.

For both issues the errors were the same:

level=warning msg="[runner] Can't process result by diff processor:
can't prepare diff by revgrep: could not read git repo: 
error executing git diff \"{revisionFrom}\" \"\"
: exit status 128"

As no one stumbled upon the seconde case I really thought I was in the same situation as the first case which made me spend a lot of time on the fix. I think it'd be a great improvment to have the error in the fmt.Errorf message.

amenasria commented 1 year ago

Made a PR about this: #19. Down for a review whenever you have time !

amenasria commented 9 months ago

Small bump on this !

bradleyfalzon commented 9 months ago

Sorry mate, will try and get time next couple of days, but within the next week definitely. Just on holiday not near laptop.

Bradley Falzon

On Fri, 26 Jan 2024 at 11:23 pm, Alexandre Menasria < @.***> wrote:

Small bump on this !

— Reply to this email directly, view it on GitHub https://github.com/bradleyfalzon/revgrep/issues/18#issuecomment-1912062428, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN74UPTKHYKBGV3V7ACKSDYQOU6PAVCNFSM6AAAAAA7MZOSOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSGA3DENBSHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

amenasria commented 9 months ago

👋 Hey, no problem Bradley, I understand !

bradleyfalzon / revgrep

`git diff` error silenced #18